Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Issue 326043004: version.py: Pass the right object to Usage in getopt exceptions. (Closed)

Created:
6 years, 6 months ago by Raphael Kubo da Costa (rakuco)
Modified:
6 years, 6 months ago
Reviewers:
Mark Mentovai, brettw
CC:
chromium-reviews
Visibility:
Public.

Description

version.py: Pass the right object to Usage in getopt exceptions. Usage() expects a string, not a full GetoptError object. TEST=build/util/version.py --file chrome/VERSION --blargh R=brettw@chromium.org, mark@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276315

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/util/version.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Raphael Kubo da Costa (rakuco)
6 years, 6 months ago (2014-06-10 12:26:16 UTC) #1
Mark Mentovai
LGTM
6 years, 6 months ago (2014-06-10 13:01:05 UTC) #2
Raphael Kubo da Costa (rakuco)
The CQ bit was checked by raphael.kubo.da.costa@intel.com
6 years, 6 months ago (2014-06-10 14:38:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raphael.kubo.da.costa@intel.com/326043004/1
6 years, 6 months ago (2014-06-10 14:42:46 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 6 months ago (2014-06-10 22:05:42 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-10 22:33:32 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/161253)
6 years, 6 months ago (2014-06-10 22:33:33 UTC) #7
Raphael Kubo da Costa (rakuco)
The CQ bit was checked by raphael.kubo.da.costa@intel.com
6 years, 6 months ago (2014-06-11 07:48:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raphael.kubo.da.costa@intel.com/326043004/1
6 years, 6 months ago (2014-06-11 07:50:41 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-11 09:13:23 UTC) #10
Message was sent while issue was closed.
Change committed as 276315

Powered by Google App Engine
This is Rietveld 408576698