Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: chrome/browser/ui/panels/docked_panel_collection.cc

Issue 326043002: Cleanup: Remove more dead GTK code. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: fix accidental revert Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/find_bar/find_bar_host_browsertest.cc ('k') | chrome/browser/ui/panels/panel_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/panels/docked_panel_collection.cc
===================================================================
--- chrome/browser/ui/panels/docked_panel_collection.cc (revision 277810)
+++ chrome/browser/ui/panels/docked_panel_collection.cc (working copy)
@@ -32,13 +32,6 @@
// After the time expires, we bring up/down the titlebars as planned.
const int kMaxDelayWaitForBottomBarVisibilityChangeMs = 1000;
-// See usage below.
-#if defined(TOOLKIT_GTK)
-const int kDelayBeforeCollapsingFromTitleOnlyStateMs = 2000;
-#else
-const int kDelayBeforeCollapsingFromTitleOnlyStateMs = 0;
-#endif
-
// After focus changed, one panel lost active status, another got it,
// we refresh layout with a delay.
const int kRefreshLayoutAfterActivePanelChangeDelayMs = 600; // arbitrary
@@ -537,19 +530,6 @@
}
}
- // On some OSes, the interaction with native Taskbars/Docks may be improved
- // if the panels do not go back to minimized state too fast. For example,
- // with a taskbar in auto-hide mode, the taskbar will cover the panel in
- // title-only mode which appears on hover. Leaving it up for a little longer
- // would allow the user to be able to click on it.
- //
- // Currently, no platforms use both delays.
- DCHECK(task_delay_ms == 0 ||
- kDelayBeforeCollapsingFromTitleOnlyStateMs == 0);
- if (!bring_up && task_delay_ms == 0) {
- task_delay_ms = kDelayBeforeCollapsingFromTitleOnlyStateMs;
- }
-
// OnAutoHidingDesktopBarVisibilityChanged will handle this.
delayed_titlebar_action_ = bring_up ? BRING_UP : BRING_DOWN;
« no previous file with comments | « chrome/browser/ui/find_bar/find_bar_host_browsertest.cc ('k') | chrome/browser/ui/panels/panel_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698