Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Unified Diff: chrome/browser/ui/panels/stacked_panel_browsertest.cc

Issue 326043002: Cleanup: Remove more dead GTK code. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: sergeyu comments try 2 Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/panels/stacked_panel_browsertest.cc
===================================================================
--- chrome/browser/ui/panels/stacked_panel_browsertest.cc (revision 275947)
+++ chrome/browser/ui/panels/stacked_panel_browsertest.cc (working copy)
@@ -1116,17 +1116,8 @@
panel_manager->CloseAll();
}
-// Skip the test since system-minimize might not be supported for some window
-// managers on Linux.
-#if defined(TOOLKIT_GTK)
-#define MAYBE_AddNewPanelNotWithSystemMinimizedDetachedPanel \
- DISABLED_AddNewPanelNotWithSystemMinimizedDetachedPanel
-#else
-#define MAYBE_AddNewPanelNotWithSystemMinimizedDetachedPanel \
- AddNewPanelNotWithSystemMinimizedDetachedPanel
-#endif
IN_PROC_BROWSER_TEST_F(StackedPanelBrowserTest,
- MAYBE_AddNewPanelNotWithSystemMinimizedDetachedPanel) {
+ AddNewPanelNotWithSystemMinimizedDetachedPanel) {
PanelManager* panel_manager = PanelManager::GetInstance();
// Create 1 detached panel.
@@ -1153,17 +1144,8 @@
panel_manager->CloseAll();
}
-// Skip the test since system-minimize might not be supported for some window
-// managers on Linux.
-#if defined(TOOLKIT_GTK)
-#define MAYBE_AddNewPanelNotWithSystemMinimizedStack \
- DISABLED_AddNewPanelNotWithSystemMinimizedStack
-#else
-#define MAYBE_AddNewPanelNotWithSystemMinimizedStack \
- AddNewPanelNotWithSystemMinimizedStack
-#endif
IN_PROC_BROWSER_TEST_F(StackedPanelBrowserTest,
- MAYBE_AddNewPanelNotWithSystemMinimizedStack) {
+ AddNewPanelNotWithSystemMinimizedStack) {
PanelManager* panel_manager = PanelManager::GetInstance();
// Create one stack with 2 panels.
@@ -1252,15 +1234,7 @@
panel_manager->CloseAll();
}
-// Skip the test since active state might not be fully supported for some window
-// managers.
-#if defined(TOOLKIT_GTK) || defined(OS_MACOSX)
-#define MAYBE_FocusNextPanelOnPanelClose DISABLED_FocusNextPanelOnPanelClose
-#else
-#define MAYBE_FocusNextPanelOnPanelClose FocusNextPanelOnPanelClose
-#endif
-IN_PROC_BROWSER_TEST_F(StackedPanelBrowserTest,
- MAYBE_FocusNextPanelOnPanelClose) {
+IN_PROC_BROWSER_TEST_F(StackedPanelBrowserTest, FocusNextPanelOnPanelClose) {
PanelManager* panel_manager = PanelManager::GetInstance();
// Create 3 stacked panels.
@@ -1285,17 +1259,8 @@
panel_manager->CloseAll();
}
-// Skip the test since active state might not be fully supported for some window
-// managers.
-#if defined(TOOLKIT_GTK) || defined(OS_MACOSX)
-#define MAYBE_FocusNextUnminimizedPanelOnPanelClose \
- DISABLED_FocusNextUnminimizedPanelOnPanelClose
-#else
-#define MAYBE_FocusNextUnminimizedPanelOnPanelClose \
- FocusNextUnminimizedPanelOnPanelClose
-#endif
IN_PROC_BROWSER_TEST_F(StackedPanelBrowserTest,
- MAYBE_FocusNextUnminimizedPanelOnPanelClose) {
+ FocusNextUnminimizedPanelOnPanelClose) {
PanelManager* panel_manager = PanelManager::GetInstance();
// Create 3 stacked panels.
@@ -1471,7 +1436,7 @@
EXPECT_TRUE(panel1_testing->IsWindowVisible());
EXPECT_TRUE(panel2_testing->IsWindowVisible());
- // Panels' visibility should not be affected when entering full-screen mode.
+ // Panels' visibility should not be affected when entering full-screen mode.
mock_display_settings_provider()->EnableFullScreenMode(true);
EXPECT_TRUE(panel1_testing->IsWindowVisible());
EXPECT_TRUE(panel2_testing->IsWindowVisible());

Powered by Google App Engine
This is Rietveld 408576698