Cleanup: Remove more dead GTK code.

Cleanup: Remove more dead GTK code.

TBR=sky@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277881

[Lei Zhang, 2014-06-10 05:12:31]

https://codereview.chromium.org/326043002/diff/40001/chrome/browser/profiles/...
File chrome/browser/profiles/profile_impl.cc (left):

https://codereview.chromium.org/326043002/diff/40001/chrome/browser/profiles/...
chrome/browser/profiles/profile_impl.cc:148: // Constrict us to a very specific
platform and architecture to make sure
Do we want to keep this and switch it to Aura?

[Sergey Ulanov, 2014-06-10 05:29:39]

https://codereview.chromium.org/326043002/diff/40001/remoting/host/it2me/it2m...
File remoting/host/it2me/it2me_native_messaging_host_main.cc (left):

https://codereview.chromium.org/326043002/diff/40001/remoting/host/it2me/it2m...
remoting/host/it2me/it2me_native_messaging_host_main.cc:65: // Cannot use
TOOLKIT_GTK because it is not defined when aura is enabled.
Please don't remove this stuff. We still use GTK in the remoting host and will
keep it for foreseeable future.

https://codereview.chromium.org/326043002/diff/40001/remoting/host/remoting_m...
File remoting/host/remoting_me2me_host.cc (left):

https://codereview.chromium.org/326043002/diff/40001/remoting/host/remoting_m...
remoting/host/remoting_me2me_host.cc:1322: #if defined(TOOLKIT_GTK)
This needs to changed to OS_LINUX, but we don't won't to remove this code
completely.

[Lei Zhang, 2014-06-10 05:38:39]

https://codereview.chromium.org/326043002/diff/40001/remoting/host/remoting_m...
File remoting/host/remoting_me2me_host.cc (left):

https://codereview.chromium.org/326043002/diff/40001/remoting/host/remoting_m...
remoting/host/remoting_me2me_host.cc:1322: #if defined(TOOLKIT_GTK)
On 2014/06/10 05:29:39, Sergey Ulanov wrote:
> This needs to changed to OS_LINUX, but we don't won't to remove this code
> completely.

but ui/gfx/gtk_util.h doesn't exist anymore and gfx::GtkInitFromCommandLine) is
now in chrome/browser/ui/libgtk2ui/gtk2_util.h. Do you want me to copy it out
here instead?

[Sergey Ulanov, 2014-06-10 06:05:56]

https://codereview.chromium.org/326043002/diff/40001/remoting/host/remoting_m...
File remoting/host/remoting_me2me_host.cc (left):

https://codereview.chromium.org/326043002/diff/40001/remoting/host/remoting_m...
remoting/host/remoting_me2me_host.cc:1322: #if defined(TOOLKIT_GTK)
On 2014/06/10 05:38:39, Lei Zhang wrote:
> On 2014/06/10 05:29:39, Sergey Ulanov wrote:
> > This needs to changed to OS_LINUX, but we don't won't to remove this code
> > completely.
> 
> but ui/gfx/gtk_util.h doesn't exist anymore and gfx::GtkInitFromCommandLine)
is
> now in chrome/browser/ui/libgtk2ui/gtk2_util.h. Do you want me to copy it out
> here instead?

We can't depend on src/chrome here. Please replace gfx::GtkInitFromCommandLine()
with  gtk_init(NULL, NULL), same as in
remoting/host/it2me/it2me_native_messaging_host_main.cc .
Thank you!

[Lei Zhang, 2014-06-10 07:02:28]

https://codereview.chromium.org/326043002/diff/40001/remoting/host/remoting_m...
File remoting/host/remoting_me2me_host.cc (left):

https://codereview.chromium.org/326043002/diff/40001/remoting/host/remoting_m...
remoting/host/remoting_me2me_host.cc:1322: #if defined(TOOLKIT_GTK)
On 2014/06/10 06:05:55, Sergey Ulanov wrote:
> On 2014/06/10 05:38:39, Lei Zhang wrote:
> > On 2014/06/10 05:29:39, Sergey Ulanov wrote:
> > > This needs to changed to OS_LINUX, but we don't won't to remove this code
> > > completely.
> > 
> > but ui/gfx/gtk_util.h doesn't exist anymore and gfx::GtkInitFromCommandLine)
> is
> > now in chrome/browser/ui/libgtk2ui/gtk2_util.h. Do you want me to copy it
out
> > here instead?
> 
> We can't depend on src/chrome here. Please replace
gfx::GtkInitFromCommandLine()
> with  gtk_init(NULL, NULL), same as in
> remoting/host/it2me/it2me_native_messaging_host_main.cc .
> Thank you! 

Done.

[Sergey Ulanov, 2014-06-10 07:58:38]

remoting LGTM when my comment is addressed

https://codereview.chromium.org/326043002/diff/100001/remoting/host/remoting_...
File remoting/host/remoting_me2me_host.cc (right):

https://codereview.chromium.org/326043002/diff/100001/remoting/host/remoting_...
remoting/host/remoting_me2me_host.cc:1321: gtk_init(NULL, NULL);
Please add
#include <gtk/gtk.h>

[Lei Zhang, 2014-06-14 01:22:38]

erg: ping

[Elliot Glaysher, 2014-06-16 17:40:03]

lgtm

[Lei Zhang, 2014-06-16 21:20:34]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-06-16 21:22:00]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/thestig@chromium.org/326043002/160001

[Lei Zhang, 2014-06-16 23:20:49]

The CQ bit was unchecked by thestig@chromium.org

[Lei Zhang, 2014-06-16 23:22:27]

TBR sky@ for trivial content/browser code deletion.

[Lei Zhang, 2014-06-16 23:22:31]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-06-16 23:23:01]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/thestig@chromium.org/326043002/180001

[Lei Zhang, 2014-06-17 01:37:39]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-06-17 01:38:02]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/thestig@chromium.org/326043002/200001

[commit-bot: I haz the power, 2014-06-17 09:52:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-17 09:52:53]

Try jobs failed on following builders:
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)

[Lei Zhang, 2014-06-17 18:48:02]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-06-17 18:51:39]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/thestig@chromium.org/326043002/220001

[commit-bot: I haz the power, 2014-06-17 22:15:53]

Change committed as 277881