Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(52)

Issue 326015: First attempt at fixing a crash that occurs when we get into WebFrameLoaderCl... (Closed)

Created:
9 years, 11 months ago by Nate Chapin
Modified:
8 years, 2 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

First attempt at fixing a crash that occurs when we get into WebFrameLoaderClient::dispatchDidChangeLocationWithinPage() with an empty redirect chain. BUG=22205 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30496

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M webkit/glue/webframeloaderclient_impl.cc View 1 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
darin (slow to review)
http://codereview.chromium.org/326015/diff/1/2 File webkit/glue/webframeloaderclient_impl.cc (right): http://codereview.chromium.org/326015/diff/1/2#newcode498 Line 498: KURL chain_end = KURL(); nit: just do "KURL ...
9 years, 11 months ago (2009-10-23 20:38:14 UTC) #1
darin (slow to review)
also, this needs a test of some sort. a layout test would be fine.
9 years, 11 months ago (2009-10-23 20:38:29 UTC) #2
Nate Chapin
I'll see what I can do, though thus far I've had trouble finding a suitable ...
9 years, 11 months ago (2009-10-23 20:49:52 UTC) #3
darin (slow to review)
okay.... so this is a patch based on crash analysis data? -darin On Fri, Oct ...
9 years, 11 months ago (2009-10-23 20:52:37 UTC) #4
Nate Chapin
On 2009/10/23 20:52:37, darin wrote: > okay.... so this is a patch based on crash ...
9 years, 10 months ago (2009-10-29 17:14:24 UTC) #5
darin (slow to review)
9 years, 10 months ago (2009-10-29 17:50:02 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld 408576698