DevTools: minor improvements of CodeGenerator code.

DevTools: minor improvements of CodeGenerator code.

result declaration was moved close to the usage:

     TypeBuilder::HeapProfiler::HeapSnapshotObjectId out_heapSnapshotObjectId;

-    RefPtr<JSONObject> result = JSONObject::create();
     if (protocolErrors->length()) {
         reportProtocolError(&callId, InvalidParams, String::format(InvalidParamsFormatString, commandName(kHeapProfiler_getHeapObjectIdCmd)), protocolErrors);
         return;
     }
     ErrorString error;
+    RefPtr<JSONObject> result = JSONObject::create();
     m_heapProfilerAgent->getHeapObjectId(&error, in_objectId, &out_heapSnapshotObjectId);
     if (!error.length()) {
         result->setString("heapSnapshotObjectId", out_heapSnapshotObjectId);

BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175888

[yurys, 2014-06-10 11:09:22]

lgtm

[loislo, 2014-06-10 11:16:56]

The CQ bit was checked by loislo@chromium.org

[commit-bot: I haz the power, 2014-06-10 11:17:07]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/loislo@chromium.org/326013005/1

[commit-bot: I haz the power, 2014-06-10 12:26:45]

Change committed as 175888

[aandrey, 2014-06-10 14:50:41]

FYI

https://codereview.chromium.org/326013005/diff/1/Source/core/inspector/CodeGe...
File Source/core/inspector/CodeGeneratorInspector.py (right):

https://codereview.chromium.org/326013005/diff/1/Source/core/inspector/CodeGe...
Source/core/inspector/CodeGeneratorInspector.py:1890: line_list.append("   
jsonMessage->setObject(\"params\", paramsObject);\n")
more improvements: paramsObject -> paramsObject.release()

https://codereview.chromium.org/326013005/diff/1/Source/core/inspector/CodeGe...
Source/core/inspector/CodeGeneratorInspector.py:2022:
send_response_call_params_list.append("result")
more improvements: result -> result.release()

https://codereview.chromium.org/326013005/diff/1/Source/core/inspector/CodeGe...
File Source/core/inspector/CodeGeneratorInspectorStrings.py (right):

https://codereview.chromium.org/326013005/diff/1/Source/core/inspector/CodeGe...
Source/core/inspector/CodeGeneratorInspectorStrings.py:78: $code   
sendIfActive(jsonMessage, ErrorString(), PassRefPtr<JSONValue>());
jsonMessage.release()

https://codereview.chromium.org/326013005/diff/1/Source/core/inspector/CodeGe...
Source/core/inspector/CodeGeneratorInspectorStrings.py:268: sendResponse(callId,
invocationError, RefPtr<JSONValue>(), result);
RefPtr -> PassRefPtr

https://codereview.chromium.org/326013005/diff/1/Source/core/inspector/CodeGe...
Source/core/inspector/CodeGeneratorInspectorStrings.py:272: sendResponse(callId,
invocationError, RefPtr<JSONValue>(), JSONObject::create());
ditto

https://codereview.chromium.org/326013005/diff/1/Source/core/inspector/CodeGe...
Source/core/inspector/CodeGeneratorInspectorStrings.py:388:
message->setObject("error", error);
error.release()