rebaseline_server: merge identical results (across multiple builders/configs) into a single row

rebaseline_server: merge identical results (across multiple builders/configs) into a single row

BUG=skia:2534
Committed: https://skia.googlesource.com/skia/+/6b28120e4c5e05a68e4947a3558f8d6615720a6e

[epoger, 2014-06-10 03:24:41]

The code is not ready for review yet.  For now, can you please try out the UI
and tell me what you think?

Please go to https://goto.google.com/wvevy , scroll down a bit so you can see
the merged rows, and experiment with moving a chunk of the rows between the
Unfiled and Hidden tabs.

[bsalomon, 2014-06-10 13:29:38]

On 2014/06/10 03:24:41, epoger wrote:
> The code is not ready for review yet.  For now, can you please try out the UI
> and tell me what you think?
> 
> Please go to https://goto.google.com/wvevy , scroll down a bit so you can see
> the merged rows, and experiment with moving a chunk of the rows between the
> Unfiled and Hidden tabs.

The UI lgtm. One tiny suggestion is to use a different horizontal border style
between rows within an image set and those between image sets. How does the
sorting work with the groupings? Also, I just noticed that if I filter on
"Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Release" then I see a row for the
entry but no images.

[epoger, 2014-06-10 13:50:16]

On 2014/06/10 13:29:38, bsalomon wrote:
> On 2014/06/10 03:24:41, epoger wrote:
> > The code is not ready for review yet.  For now, can you please try out the
UI
> > and tell me what you think?
> > 
> > Please go to https://goto.google.com/wvevy , scroll down a bit so you can
see
> > the merged rows, and experiment with moving a chunk of the rows between the
> > Unfiled and Hidden tabs.
> 
> The UI lgtm. One tiny suggestion is to use a different horizontal border style
> between rows within an image set and those between image sets. How does the
> sorting work with the groupings?

Discussed live with Brian.  We will experiment with the horizontal border style,
and also maybe alternating color pairs as you scroll down?  (Rows of the first
merged set alternate between colors 1&2, second merged set alternates between
colors 3&4)

More importantly, we decided that we should definitely have a "sort by maximal
grouping" option, to make rebaselining as easy as possible.

> Also, I just noticed that if I filter on
> "Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Release" then I see a row for the
> entry but no images.

Ooh, you found a good corner-case there.  (Filtered results that yield exactly
one match.)  Thanks!

I'll work on all of the above, and then ask for more feedback.

[epoger, 2014-06-10 19:21:09]

Brian/others: please go to https://goto.google.com/wvevy and try out the UI
again, and let me know if you think it's ready to move on to the code review
stage.

In patchset 2, I have:
- fixed the exactly-one-match corner case Brian caught
- added maximal grouping as a second-order sort (so no matter which column you
are sorting on, the results will be arranged in the biggest chunks possible)
- added ability to sort by expected image or actual image

The default sort--by perceptual difference, and then maximal grouping as a
tiebreaker--will give the largest chunks of merged results possible, and should
be best for most rebaselining activities.

I have NOT experimented with the following items yet.  I'd like to leave them
for a future CL:
- horizontal border style
- alternating color pairs as you scroll down

On 2014/06/10 13:50:16, epoger wrote:
> On 2014/06/10 13:29:38, bsalomon wrote:
> > On 2014/06/10 03:24:41, epoger wrote:
> > > The code is not ready for review yet.  For now, can you please try out the
> UI
> > > and tell me what you think?
> > > 
> > > Please go to https://goto.google.com/wvevy , scroll down a bit so you can
> see
> > > the merged rows, and experiment with moving a chunk of the rows between
the
> > > Unfiled and Hidden tabs.
> > 
> > The UI lgtm. One tiny suggestion is to use a different horizontal border
style
> > between rows within an image set and those between image sets. How does the
> > sorting work with the groupings?
> 
> Discussed live with Brian.  We will experiment with the horizontal border
style,
> and also maybe alternating color pairs as you scroll down?  (Rows of the first
> merged set alternate between colors 1&2, second merged set alternates between
> colors 3&4)
> 
> More importantly, we decided that we should definitely have a "sort by maximal
> grouping" option, to make rebaselining as easy as possible.
> 
> > Also, I just noticed that if I filter on
> > "Test-Mac10.6-MacMini4.1-GeForce320M-x86_64-Release" then I see a row for
the
> > entry but no images.
> 
> Ooh, you found a good corner-case there.  (Filtered results that yield exactly
> one match.)  Thanks!
> 
> I'll work on all of the above, and then ask for more feedback.

[epoger, 2014-06-10 19:56:53]

OK, Greg, it's ready for code review.  PTAL at patchset 3.

[epoger, 2014-06-11 19:18:05]

Greg got blocked on something else, so Joe is gonna review it today.

[epoger, 2014-06-11 19:18:56]

P.S. It's still available to try out at https://goto.google.com/wvevy

[jcgregorio, 2014-06-11 20:45:51]

On 2014/06/11 19:18:56, epoger wrote:
> P.S. It's still available to try out at https://goto.google.com/wvevy

LGTM

[epoger, 2014-06-11 20:49:35]

The CQ bit was checked by epoger@google.com

[commit-bot: I haz the power, 2014-06-11 20:49:59]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/epoger@google.com/326013002/40001

[commit-bot: I haz the power, 2014-06-11 21:01:39]

Change committed as 6b28120e4c5e05a68e4947a3558f8d6615720a6e