Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7356)

Unified Diff: chrome/browser/ui/webui/ntp/ntp_resource_cache.cc

Issue 325963007: Do not append Google locale to help center links (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/ntp/ntp_resource_cache.cc
diff --git a/chrome/browser/ui/webui/ntp/ntp_resource_cache.cc b/chrome/browser/ui/webui/ntp/ntp_resource_cache.cc
index 772714edc605b6a40ec4a3e03c5ec0bafc22eccb..8a6dd2e97ec2de47a9dd6552cc563e528f809f30 100644
--- a/chrome/browser/ui/webui/ntp/ntp_resource_cache.cc
+++ b/chrome/browser/ui/webui/ntp/ntp_resource_cache.cc
@@ -82,7 +82,7 @@ const char kLearnMoreGuestSessionUrl[] =
"https://www.google.com/support/chromeos/bin/answer.py?answer=1057090";
base::string16 GetUrlWithLang(const GURL& url) {
Peter Kasting 2014/06/10 18:58:25 This name is now misleading as we don't do anythin
blundell 2014/06/11 12:07:19 Done.
- return base::ASCIIToUTF16(google_util::AppendGoogleLocaleParam(url).spec());
+ return base::ASCIIToUTF16(url.spec());
}
std::string SkColorToRGBAString(SkColor color) {
@@ -463,7 +463,8 @@ void NTPResourceCache::CreateNewTabHTML() {
load_time_data.SetString("learnMore",
l10n_util::GetStringUTF16(IDS_LEARN_MORE));
load_time_data.SetString("webStoreLink",
- GetUrlWithLang(GURL(extension_urls::GetWebstoreLaunchURL())));
+ GetUrlWithLang(google_util::AppendGoogleLocaleParam(
+ GURL(extension_urls::GetWebstoreLaunchURL()))));
load_time_data.SetString("appInstallHintText",
l10n_util::GetStringUTF16(IDS_NEW_TAB_APP_INSTALL_HINT_LABEL));
load_time_data.SetBoolean("isDiscoveryInNTPEnabled",

Powered by Google App Engine
This is Rietveld 408576698