Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 325953005: Add gallery browser tests to rename an image in the slide mode. (Closed)

Created:
6 years, 6 months ago by hirono
Modified:
6 years, 6 months ago
Reviewers:
mtomasz, fukino
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, yoshiki+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Add gallery browser tests to rename an image in the slide mode. BUG=383251 TEST=run the test. R=fukino@chromium.org, mtomasz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276547

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Add a missing comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -0 lines) Patch
M chrome/browser/chromeos/file_manager/file_manager_browsertest.cc View 1 chunk +23 lines, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_manager_browsertest/gallery/slide_mode.js View 1 2 chunks +48 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
hirono
PTAL the CL? Thank you!
6 years, 6 months ago (2014-06-11 07:43:24 UTC) #1
fukino
On 2014/06/11 07:43:24, hirono wrote: > PTAL the CL? Thank you! LGTM!
6 years, 6 months ago (2014-06-11 08:05:31 UTC) #2
hirono
The CQ bit was checked by hirono@chromium.org
6 years, 6 months ago (2014-06-11 08:06:58 UTC) #3
hirono
@mtomasz - PTAL the CL? Thank you!
6 years, 6 months ago (2014-06-11 08:07:24 UTC) #4
hirono
6 years, 6 months ago (2014-06-11 08:07:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/325953005/40001
6 years, 6 months ago (2014-06-11 08:10:23 UTC) #6
hirono
The CQ bit was unchecked by hirono@chromium.org
6 years, 6 months ago (2014-06-11 08:23:44 UTC) #7
mtomasz
lgtm! with a nit https://codereview.chromium.org/325953005/diff/40001/chrome/test/data/extensions/api_test/file_manager_browsertest/gallery/slide_mode.js File chrome/test/data/extensions/api_test/file_manager_browsertest/gallery/slide_mode.js (right): https://codereview.chromium.org/325953005/diff/40001/chrome/test/data/extensions/api_test/file_manager_browsertest/gallery/slide_mode.js#newcode72 chrome/test/data/extensions/api_test/file_manager_browsertest/gallery/slide_mode.js:72: * Runs a test to ...
6 years, 6 months ago (2014-06-11 09:44:47 UTC) #8
hirono
Thank you! https://codereview.chromium.org/325953005/diff/40001/chrome/test/data/extensions/api_test/file_manager_browsertest/gallery/slide_mode.js File chrome/test/data/extensions/api_test/file_manager_browsertest/gallery/slide_mode.js (right): https://codereview.chromium.org/325953005/diff/40001/chrome/test/data/extensions/api_test/file_manager_browsertest/gallery/slide_mode.js#newcode72 chrome/test/data/extensions/api_test/file_manager_browsertest/gallery/slide_mode.js:72: * Runs a test to rename an ...
6 years, 6 months ago (2014-06-11 09:56:41 UTC) #9
hirono
The CQ bit was checked by hirono@chromium.org
6 years, 6 months ago (2014-06-11 09:56:44 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/325953005/60001
6 years, 6 months ago (2014-06-11 09:57:41 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 16:02:06 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 21:00:30 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/builds/19504)
6 years, 6 months ago (2014-06-11 21:00:31 UTC) #14
hirono
The CQ bit was checked by hirono@chromium.org
6 years, 6 months ago (2014-06-12 02:30:09 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/325953005/60001
6 years, 6 months ago (2014-06-12 02:32:27 UTC) #16
hirono
6 years, 6 months ago (2014-06-12 05:54:22 UTC) #17
Message was sent while issue was closed. 
Committed patchset #2 manually as r276547 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698