Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 325893002: Bluetooth: add socket & low_energy manifest check (Closed)

Created:
6 years, 6 months ago by keybuk
Modified:
6 years, 6 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Bluetooth: add socket & low_energy manifest check In order to use the chrome.bluetoothSocket and chrome.bluetoothLowEnergy APIs you will need to add "socket": true or "low_energy": true respectively to the "bluetooth" manifest section. BUG=376607, 365839 TEST=tests updated Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276370

Patch Set 1 #

Patch Set 2 : add permission denied tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+233 lines, -50 lines) Patch
M chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_api.cc View 3 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_apitest.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/bluetooth_socket/bluetooth_socket_api.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/bluetooth_socket/bluetooth_socket_apitest.cc View 1 1 chunk +13 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/bluetooth/bluetooth_manifest_data.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/bluetooth/bluetooth_manifest_data.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/bluetooth/bluetooth_manifest_permission.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/bluetooth/bluetooth_manifest_permission.cc View 3 chunks +19 lines, -1 line 0 comments Download
M chrome/common/extensions/api/manifest_types.json View 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/common/extensions/docs/templates/articles/app_bluetooth.html View 1 chunk +24 lines, -4 lines 0 comments Download
M chrome/common/extensions/docs/templates/articles/manifest/bluetooth.html View 1 chunk +19 lines, -3 lines 0 comments Download
M chrome/test/data/extensions/api_test/bluetooth_low_energy/characteristic_properties/manifest.json View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/bluetooth_low_energy/characteristic_value_changed/manifest.json View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/bluetooth_low_energy/descriptor_value_changed/manifest.json View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/bluetooth_low_energy/get_characteristic/manifest.json View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/bluetooth_low_energy/get_characteristics/manifest.json View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/bluetooth_low_energy/get_descriptor/manifest.json View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/bluetooth_low_energy/get_descriptors/manifest.json View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/bluetooth_low_energy/get_included_services/manifest.json View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/bluetooth_low_energy/get_removed_characteristic/manifest.json View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/bluetooth_low_energy/get_removed_descriptor/manifest.json View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/bluetooth_low_energy/get_removed_service/manifest.json View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/bluetooth_low_energy/get_service/manifest.json View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/bluetooth_low_energy/get_services/manifest.json View 1 chunk +3 lines, -1 line 0 comments Download
A + chrome/test/data/extensions/api_test/bluetooth_low_energy/permission_denied/manifest.json View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/test/data/extensions/api_test/bluetooth_low_energy/permission_denied/runtest.js View 1 1 chunk +21 lines, -20 lines 0 comments Download
M chrome/test/data/extensions/api_test/bluetooth_low_energy/read_characteristic_value/manifest.json View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/bluetooth_low_energy/read_descriptor_value/manifest.json View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/bluetooth_low_energy/service_events/manifest.json View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/bluetooth_low_energy/write_characteristic_value/manifest.json View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/bluetooth_low_energy/write_descriptor_value/manifest.json View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/bluetooth_socket/connect/manifest.json View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/bluetooth_socket/listen/manifest.json View 1 chunk +2 lines, -1 line 0 comments Download
A chrome/test/data/extensions/api_test/bluetooth_socket/permission_denied/manifest.json View 1 1 chunk +12 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/bluetooth_socket/permission_denied/runtest.js View 1 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
keybuk
miket, kalman: for OWNERS rpaquay: /api/bluetooth* owners mkearney: docs OWNERS
6 years, 6 months ago (2014-06-09 22:16:25 UTC) #1
armansito
Could you add a browser test that doesn't specify the low_energy permission and checks that ...
6 years, 6 months ago (2014-06-09 23:16:32 UTC) #2
keybuk
On 2014/06/09 23:16:32, armansito wrote: > Could you add a browser test that doesn't specify ...
6 years, 6 months ago (2014-06-10 00:23:45 UTC) #3
armansito
lgtm
6 years, 6 months ago (2014-06-10 00:36:37 UTC) #4
keybuk
The CQ bit was checked by keybuk@chromium.org
6 years, 6 months ago (2014-06-10 17:48:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keybuk@chromium.org/325893002/20001
6 years, 6 months ago (2014-06-10 17:52:10 UTC) #6
keybuk
The CQ bit was unchecked by keybuk@chromium.org
6 years, 6 months ago (2014-06-10 18:25:21 UTC) #7
miket_OOO
lgtm
6 years, 6 months ago (2014-06-10 22:37:49 UTC) #8
rpaquay
lgtm
6 years, 6 months ago (2014-06-10 22:55:51 UTC) #9
keybuk
The CQ bit was checked by keybuk@chromium.org
6 years, 6 months ago (2014-06-10 23:10:51 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keybuk@chromium.org/325893002/20001
6 years, 6 months ago (2014-06-10 23:12:16 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 01:41:16 UTC) #12
commit-bot: I haz the power
6 years, 6 months ago (2014-06-11 12:52:40 UTC) #13
Message was sent while issue was closed. 
Change committed as 276370

Powered by Google App Engine
This is Rietveld 408576698