Issue 325843002: Add some missing header include guards

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 325843002: Add some missing header include guards (Closed)

Created:
6 years, 6 months ago by gw280

Modified:
6 years, 6 months ago

Reviewers:
tfarina, bsalomon, reed1

CC:
skia-review_googlegroups.com, reed1

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

Add some missing header include guards BUG=skia: R=bsalomon@google.com Committed: https://skia.googlesource.com/skia/+/9eb182ac4bcdc38f71a603ba958ff889fbbf5d77

Patch Set 2 : Moved header guards as per tfarina's comment #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -1 line)			Patch
M	src/gpu/GrAAConvexPathRenderer.h	View	1	2 chunks	+5 lines, -1 line	0 comments	Download
M	src/gpu/GrReducedClip.h	View		2 chunks	+5 lines, -0 lines	0 comments	Download
M	src/pathops/SkLineParameters.h	View		2 chunks	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

tfarina

lgtm, with the following fix. https://codereview.chromium.org/325843002/diff/1/src/gpu/GrAAConvexPathRenderer.h File src/gpu/GrAAConvexPathRenderer.h (right): https://codereview.chromium.org/325843002/diff/1/src/gpu/GrAAConvexPathRenderer.h#newcode11 src/gpu/GrAAConvexPathRenderer.h:11: #ifndef GrAAConvexPathRenderer_DEFINED please, put ...

6 years, 6 months ago (2014-06-09 18:42:10 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/george@mozilla.com/325843002/20001

6 years, 6 months ago (2014-06-20 18:35:18 UTC) #5

commit-bot: I haz the power

6 years, 6 months ago (2014-06-20 19:01:10 UTC) #6

Message was sent while issue was closed.

Change committed as 9eb182ac4bcdc38f71a603ba958ff889fbbf5d77

Expand Messages | Collapse Messages

Issue 325843002: Add some missing header include guards (Closed)

Description

Patch Set 1 #

Patch Set 2 : Moved header guards as per tfarina's comment #

Messages