DevTools: eliminate 1k lines of generated code in InspectorBackendDispatcher.cpp

DevTools: eliminate 1k lines of generated code in InspectorBackendDispatcher.cpp

and reduce binary footprint by 5% ~25kb of 587k (clang x64 release)

BUG=382569
R=yurys@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175877

[yurys, 2014-06-10 07:36:20]

lgtm

https://codereview.chromium.org/325833002/diff/1/Source/core/inspector/CodeGe...
File Source/core/inspector/CodeGeneratorInspectorStrings.py (left):

https://codereview.chromium.org/325833002/diff/1/Source/core/inspector/CodeGe...
Source/core/inspector/CodeGeneratorInspectorStrings.py:49: RefPtr<JSONArray>
protocolErrors = JSONArray::create();
I'd rather we left previous implementation where protocolErrors was a local
variable inside the method as it is used only here. I don't see why we should
pass it as argument unless there may be errors passed by the caller.

[loislo, 2014-06-10 09:03:19]

On 2014/06/10 07:36:20, yurys wrote:
> lgtm
> 
>
https://codereview.chromium.org/325833002/diff/1/Source/core/inspector/CodeGe...
> File Source/core/inspector/CodeGeneratorInspectorStrings.py (left):
> 
>
https://codereview.chromium.org/325833002/diff/1/Source/core/inspector/CodeGe...
> Source/core/inspector/CodeGeneratorInspectorStrings.py:49: RefPtr<JSONArray>
> protocolErrors = JSONArray::create();
> I'd rather we left previous implementation where protocolErrors was a local
> variable inside the method as it is used only here. I don't see why we should
> pass it as argument unless there may be errors passed by the caller.

Actually exactly this movement gives us these 25k of object file size.

[loislo, 2014-06-10 09:03:35]

The CQ bit was checked by loislo@chromium.org

[commit-bot: I haz the power, 2014-06-10 09:04:20]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/loislo@chromium.org/325833002/1

[loislo, 2014-06-10 09:39:20]

Committed patchset #1 manually as r175877 (presubmit successful).