Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 32583007: Add UseCounter for HTMLSourceElement.media (Closed)

Created:
7 years, 2 months ago by philipj_slow
Modified:
7 years, 2 months ago
Reviewers:
Mike West
CC:
blink-reviews, feature-media-reviews_chromium.org, dglazkov+blink, nessy, vcarbune.chromium, adamk+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Add UseCounter for HTMLSourceElement.media https://www.w3.org/Bugs/Public/show_bug.cgi?id=19619 By counting the number of candidate <source> elements and the number of non-matching media attributes, we can determine what the impact of removing the attribute from spec and implementation would be. BUG=310006 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160190

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M Source/core/html/HTMLMediaElement.cpp View 2 chunks +4 lines, -1 line 0 comments Download
M Source/core/page/UseCounter.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
philipj_slow
See https://www.w3.org/Bugs/Public/show_bug.cgi?id=19619#c25
7 years, 2 months ago (2013-10-22 09:01:04 UTC) #1
Mike West
lgtm LGTM
7 years, 2 months ago (2013-10-22 09:06:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/32583007/1
7 years, 2 months ago (2013-10-22 09:07:13 UTC) #3
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
7 years, 2 months ago (2013-10-22 11:33:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/32583007/1
7 years, 2 months ago (2013-10-22 11:35:39 UTC) #5
commit-bot: I haz the power
7 years, 2 months ago (2013-10-22 11:37:30 UTC) #6
Message was sent while issue was closed.
Change committed as 160190

Powered by Google App Engine
This is Rietveld 408576698