Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 325723002: Fix Chrome build after 9f1c241e (https://codereview.chromium.org/316143003/) (Closed)

Created:
6 years, 6 months ago by robertphillips
Modified:
6 years, 6 months ago
Reviewers:
scroggo
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Fix Chrome build after 9f1c241e (https://codereview.chromium.org/316143003/) Remove SkPicture::kUsePathBoundsForClip_RecordingFlag (https://codereview.chromium.org/316143003/) removed an SkPicture flag on which Chromium still relies. TBR=scroggo@google.com NOTRY=true Committed: https://skia.googlesource.com/skia/+/e2b78a7131a9ee7dccdc3b056bdbaeaad851fc81

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M gyp/skia_for_chromium_defines.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
robertphillips
6 years, 6 months ago (2014-06-09 14:04:39 UTC) #1
robertphillips
The CQ bit was checked by robertphillips@google.com
6 years, 6 months ago (2014-06-09 14:04:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/325723002/1
6 years, 6 months ago (2014-06-09 14:05:01 UTC) #3
commit-bot: I haz the power
Change committed as e2b78a7131a9ee7dccdc3b056bdbaeaad851fc81
6 years, 6 months ago (2014-06-09 14:05:09 UTC) #4
scroggo
6 years, 6 months ago (2014-06-09 14:07:32 UTC) #5
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698