Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(871)

Issue 325683003: Reland Initial ServiceWorker Cache API polyfill. (Closed)

Created:
6 years, 6 months ago by gavinp
Modified:
6 years, 6 months ago
Reviewers:
falken, jsbell, dcheng
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org, alecflett+watch_chromium.org
Visibility:
Public.

Description

Reland Initial ServiceWorker Cache API polyfill. Originally landed as r175749, this had to revert because of a memory issue; the file arrays were not null terminated. Now using the explicit length WTFString constructor. R=jsbell@chromium.org,dcheng@chromium.org TBR=jochen@chromium.org BUG=374822 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175808

Patch Set 1 : as landed original patch #

Patch Set 2 : with memory bounds fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -0 lines) Patch
M Source/modules/modules.gyp View 1 chunk +27 lines, -0 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp View 1 2 chunks +4 lines, -0 lines 0 comments Download
A Source/modules/serviceworkers/polyfills/cachePolyfill.js View 1 chunk +112 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
gavinp
dcheng: FYI since you reverted. jsbell, can you CQ this if you approve? I'm writing ...
6 years, 6 months ago (2014-06-09 11:55:30 UTC) #1
jsbell
lgtm
6 years, 6 months ago (2014-06-09 17:33:54 UTC) #2
jsbell
The CQ bit was checked by jsbell@chromium.org
6 years, 6 months ago (2014-06-09 17:33:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gavinp@chromium.org/325683003/40001
6 years, 6 months ago (2014-06-09 17:35:02 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: blink_presubmit on tryserver.blink ...
6 years, 6 months ago (2014-06-09 17:43:28 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-09 17:45:37 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/7306)
6 years, 6 months ago (2014-06-09 17:45:38 UTC) #7
jsbell
On 2014/06/09 17:45:38, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 6 months ago (2014-06-09 17:46:16 UTC) #8
jsbell
The CQ bit was checked by jsbell@chromium.org
6 years, 6 months ago (2014-06-09 17:46:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gavinp@chromium.org/325683003/40001
6 years, 6 months ago (2014-06-09 17:47:38 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-06-09 17:50:27 UTC) #11
Message was sent while issue was closed.
Change committed as 175808

Powered by Google App Engine
This is Rietveld 408576698