Source/modules/indexeddb/IDBRequest.cpp - Issue 325683002: [IndexedDB] Use consistent enums on both sides of IPC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/indexeddb/IDBRequest.cpp

Issue 325683002: [IndexedDB] Use consistent enums on both sides of IPC. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/indexeddb/IDBObjectStore.h ('K') | « Source/modules/indexeddb/IDBRequest.h ('k') | Source/modules/indexeddb/IDBTransaction.h » ('j') | Source/modules/indexeddb/InspectorIndexedDBAgent.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/indexeddb/IDBRequest.cpp

diff --git a/Source/modules/indexeddb/IDBRequest.cpp b/Source/modules/indexeddb/IDBRequest.cpp

index 22154653e3024f9951d53fea1d99fcc2e9a91c97..48fe01c39f74e9c6097418582f2ecbffabfeeac0 100644

--- a/Source/modules/indexeddb/IDBRequest.cpp

+++ b/Source/modules/indexeddb/IDBRequest.cpp

@@ -65,7 +65,7 @@ IDBRequest::IDBRequest(ScriptState* scriptState, IDBAny* source, IDBTransaction*

, m_source(source)

, m_hasPendingActivity(true)

, m_cursorType(IndexedDB::CursorKeyAndValue)

- , m_cursorDirection(blink::WebIDBCursor::Next)

+ , m_cursorDirection(blink::Next)

, m_pendingCursor(nullptr)

, m_didFireUpgradeNeededEvent(false)

, m_preventPropagation(false)

@@ -160,7 +160,7 @@ void IDBRequest::abort()

m_requestAborted = true;

}

-void IDBRequest::setCursorDetails(IndexedDB::CursorType cursorType, WebIDBCursor::Direction direction)

+void IDBRequest::setCursorDetails(IndexedDB::CursorType cursorType, blink::Direction direction)

{

ASSERT(m_readyState == PENDING);

ASSERT(!m_pendingCursor);