Source/platform/fonts/Font.cpp - Issue 325673002: Fixing handling of Ligature when letter-spacing is present

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/fonts/Font.cpp

Issue 325673002: Fixing handling of Ligature when letter-spacing is present (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/fast/text/font-ligature-letter-spacing.html ('K') | « LayoutTests/fast/text/font-ligature-letter-spacing-expected.txt ('k') | Source/platform/fonts/FontDescription.cpp » ('j') | Source/platform/fonts/FontDescription.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/platform/fonts/Font.cpp

diff --git a/Source/platform/fonts/Font.cpp b/Source/platform/fonts/Font.cpp

index a10f380fba89f8e385e2670870992912205a8638..3639348f92ccde9ada8b47e5c5abbd8d278db6e6 100644

--- a/Source/platform/fonts/Font.cpp

+++ b/Source/platform/fonts/Font.cpp

@@ -250,7 +250,7 @@ CodePath Font::codePath(const TextRun& run) const

return SimplePath;

#endif

- if (m_fontDescription.featureSettings() && m_fontDescription.featureSettings()->size() > 0)

+ if (m_fontDescription.featureSettings() && m_fontDescription.featureSettings()->size() > 0 && m_fontDescription.letterSpacing() == 0)

return ComplexPath;

if (run.length() > 1 && !WidthIterator::supportsTypesettingFeatures(*this))