Fixing handling of Ligature when letter-spacing is present

Source/platform/fonts/FontDescription.cpp

 /*
  * Copyright (C) 2007 Nicholas Shanks <contact@nickshanks.com>
  * Copyright (C) 2008 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 164 matching lines @@
     case FontDescription::NoneKerning:
         m_typesettingFeatures &= ~WebCore::Kerning;
         break;
     case FontDescription::NormalKerning:
         m_typesettingFeatures |= WebCore::Kerning;
         break;
     case FontDescription::AutoKerning:
         break;
     }
 
-    switch (commonLigaturesState()) {
-    case FontDescription::DisabledLigaturesState:
-        m_typesettingFeatures &= ~Ligatures;
-        break;
-    case FontDescription::EnabledLigaturesState:
-        m_typesettingFeatures |= Ligatures;
-        break;
-    case FontDescription::NormalLigaturesState:
-        break;
-    }
+    // As per CSS (http://www.w3.org/TR/CSS2/text.html#propdef-letter-spacing),

[Inactive, 2014/06/09 13:09:44]

Please always point to the latest version of the specs:
http://dev.w3.org/csswg/css-text-3/#letter-spacing-property

Specs are often updated and we wouldn't want to make an update to match an old
version of a spec if we already match the latest version.

FYI, the latest spec says: "When the effective letter-spacing between two
characters is not zero (due to either justification or non-zero computed
letter-spacing), user agents should not apply optional ligatures."

[h.joshi, 2014/06/09 13:33:53]

In "https://developer.mozilla.org/en-US/docs/Web/CSS/letter-spacing" CSS 2 was
written as Recommended thats why used CSS 2 link.
Made changes and included new one as suggested in new patch.

+    // when the resultant space between two characters
+    // is not the same as the default space, user agents should not use ligatures
+    if (m_letterSpacing != 0) {
+        switch (commonLigaturesState()) {
+        case FontDescription::DisabledLigaturesState:
+            m_typesettingFeatures &= ~Ligatures;
+            break;
+        case FontDescription::EnabledLigaturesState:
+            m_typesettingFeatures |= Ligatures;
+            break;
+        case FontDescription::NormalLigaturesState:
+            break;
+        }
 
-    if (discretionaryLigaturesState() == FontDescription::EnabledLigaturesState
-        || historicalLigaturesState() == FontDescription::EnabledLigaturesState
-        || contextualLigaturesState() == FontDescription::EnabledLigaturesState) {
-        m_typesettingFeatures |= WebCore::Ligatures;
+        if (discretionaryLigaturesState() == FontDescription::EnabledLigaturesState
+            || historicalLigaturesState() == FontDescription::EnabledLigaturesState
+            || contextualLigaturesState() == FontDescription::EnabledLigaturesState) {
+            m_typesettingFeatures |= WebCore::Ligatures;
+        }
     }
 }
 
 } // namespace WebCore