LayoutTests/fast/text/font-ligature-letter-spacing.html - Issue 325673002: Fixing handling of Ligature when letter-spacing is present

Side by Side Diff: LayoutTests/fast/text/font-ligature-letter-spacing.html

Issue 325673002: Fixing handling of Ligature when letter-spacing is present (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <meta http-equiv="Content-Type" content="text/html;charset=utf-8">

	5 <title>Letter spacing and Ligature</title>

	6

	7 <style type="text/css">

	8 @font-face {

	9 font-family: megalopolis;

	10 src: url(../../third_party/MEgalopolis/MEgalopolisExtra.woff) format("woff");

	11 }

	12

	13 .dligDiv {

	14 -moz-font-feature-settings:"frac" 1, "dlig" 1;

	15 -moz-font-feature-settings:"frac=1, dlig=1";

	16 -ms-font-feature-settings:"frac" 1, "dlig" 1;

	17 -o-font-feature-settings:"frac" 1, "dlig" 1;

	18 -webkit-font-feature-settings:"frac" 1, "dlig" 1;

	19 font-feature-settings:"frac" 1, "dlig" 1;

	20 }

	21

	22 .common {

	23 font-size: 24px;

	24 line-height: 100%;

	25 padding: 0px;

	26 letter-spacing:20px;

	27 font-family: megalopolis;

	28 }

	29

	30 p { font-family: serif; font-style: italic; }

	31 </style>

	32

	33 <script src="../../resources/testharness.js"></script>

	34 <script src="../../resources/testharnessreport.js"></script>

	35 <script>

	36 setup({ explicit_done: true });

	37 function testLetterSpaceAndLigature() {

	38 elementWidth_1 = document.getElementsByClassName("dligSpan")[0].getBound ingClientRect().width;
	Inactive 2014/06/09 13:14:47 Use "var" to declare variable. Also, please use be Use "var" to declare variable. Also, please use better names (e.g. elementWithLetterSpacing, elementWithoutLetterSpacing). assert_equals(elementWithLetterSpacing.getBoundingClientRect().width, elementWithoutLetterSpacing.getBoundingClientRect().width); h.joshi 2014/06/09 13:33:53 Done, using new variable in separate line as using Done, using new variable in separate line as using inside assert_equal was creating very long line.
	39 elementWidth_2 = document.getElementsByClassName("letterSpace")[0].getBo undingClientRect().width;
	Inactive 2014/06/09 13:14:46 var elementWidth_2 var elementWidth_2 h.joshi 2014/06/09 13:33:53 Changed to new name. Changed to new name.
	40 test(function() {

	41 assert_equals(elementWidth_1, elementWidth_2, "Ligature not applied due to letter spacing.");

	42 }, "Ligature expected not to be applied due to letter spacing.");

	43 done();

	44 }

	45 </script>

	46 </head>

	47
	Inactive 2014/06/09 13:14:47 No need for the blank line. No need for the blank line. h.joshi 2014/06/09 13:33:53 Blank line removed between </head> and <body> Blank line removed between </head> and <body>
	48 <body onload="testLetterSpaceAndLigature();">

	49 <div class="dligDiv common">

	50 <span class="dligSpan">CACACACA</span>

	51 </div>

	52

	53 <div class="common">

	54 <span class="letterSpace">CACACACA</span>

	55 </div>

	56

	57 <div id="log"></div>
	Inactive 2014/06/09 13:14:47 Why this div? Why this div? h.joshi 2014/06/09 13:33:53 This is used by testharness script to insert logs, This is used by testharness script to insert logs, same is used by other scripts as well.
	58 </body></html>
	Inactive 2014/06/09 13:14:47 We usually have </html> on its own line. We usually have </html> on its own line. h.joshi 2014/06/09 13:33:53 Done. Show quoted text On 2014/06/09 13:14:47, Chris Dumez wrote: > We usually have </html> on its own line. Done.
OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/text/font-ligature-letter-spacing-expected.txt » ('j') | Source/platform/fonts/FontDescription.cpp » ('J')