LayoutTests/fast/css/shadow-style-removed-out-of-document.html - Issue 325663003: Remove scoped styles (retry)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/css/shadow-style-removed-out-of-document.html

Issue 325663003: Remove scoped styles (retry) (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Reorder inDocument() check so that register/unregister should balance. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>
	tasak 2014/06/10 08:51:26 We don't need <html>, <head> and <body> if this te We don't need <html>, <head> and <body> if this test really needs <head> or <body>. (I often forget to remove these and am requested to remove) kochi 2014/06/10 09:09:05 Done. <!DOCTYPE> removed too. Show quoted text On 2014/06/10 08:51:26, tasak wrote: > We don't need <html>, <head> and <body> if this test really needs <head> or > <body>. > (I often forget to remove these and am requested to remove) Done. <!DOCTYPE> removed too.
	4 <script src="../../resources/js-test.js"></script>

	5 <script>

	6 var div = document.createElement('div');

	7 var root = div.createShadowRoot();

	8 root.innerHTML = '<style>div { color: green; }</style><div>Hello world</div>';

	9 // Remove style element before its shadow root is attached to document.

	10 root.removeChild(root.firstChild);

	11 delete root;

	12 delete div;
	tasak 2014/06/10 08:51:26 root = null and div = null? However, do we need " root = null and div = null? However, do we need "root = null" and "div = null"? If the assert failure occurs during GC, we need these. kochi 2014/06/10 09:09:05 I made sure line 10 (root.removeChild()) only is e Show quoted text On 2014/06/10 08:51:26, tasak wrote: > root = null and div = null? > > However, do we need "root = null" and "div = null"? > If the assert failure occurs during GC, we need these. I made sure line 10 (root.removeChild()) only is enough to make renderer crash without line 11-12. Removed.
	13 </script>

	14 </head>

	15 <body>

	16 Hello shadow style

	17 </body>

	18 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/css/shadow-style-removed-out-of-document-expected.txt » ('j') | no next file with comments »