[PowerProfiler] pySerial module serial.tools.list_ports for linux should include the product inform…

[PowerProfiler] pySerial module serial.tools.list_ports for linux should include the product information as description
With monsoon power monitor connected, while using serial.tools.list_ports module to see
available ports, the description field returned is always 'ttyACM0'. Whereas the same API
on windows and mac, returns 'Mobile Device Power Monitor'.

In this CL, we try to retrive the product information from the /product file associated
with this device. If we are unable to retrive, we simply return the device name itself
as is the present case.

BUG=382315
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279368

[vivekg, 2014-06-09 05:52:30]

PTAL, thank you.

[vivekg, 2014-06-09 05:58:48]

Should we modify "src/tools/telemetry/third_party/pyserial/README.chromium" as
well to include the description about changes by this CL?

[tonyg, 2014-06-09 16:04:50]

On 2014/06/09 05:58:48, vivekg_ wrote:
> Should we modify "src/tools/telemetry/third_party/pyserial/README.chromium" as
> well to include the description about changes by this CL?

This seems like a good change, but I'd prefer if we could make it upstream and
then roll it into chromium. The code is here:
http://sourceforge.net/projects/pyserial/ . Would you mind posting a patch there
to see if the author is responsive? If it takes more than a week to get a
response, then I'd be fine with patching it in chromium only.

[vivekg, 2014-06-10 03:55:32]

On 2014/06/09 16:04:50, tonyg wrote:
> This seems like a good change, but I'd prefer if we could make it upstream and
> then roll it into chromium. The code is here:
> http://sourceforge.net/projects/pyserial/ . Would you mind posting a patch
there
> to see if the author is responsive? If it takes more than a week to get a
> response, then I'd be fine with patching it in chromium only.

Sure. I have sent a mail to the author as I couldn't find any 'How to submit a
patch' link in the above URL for pyserial.

[tonyg, 2014-06-11 01:57:53]

On 2014/06/10 03:55:32, vivekg_ wrote:
> On 2014/06/09 16:04:50, tonyg wrote:
> > This seems like a good change, but I'd prefer if we could make it upstream
and
> > then roll it into chromium. The code is here:
> > http://sourceforge.net/projects/pyserial/ . Would you mind posting a patch
> there
> > to see if the author is responsive? If it takes more than a week to get a
> > response, then I'd be fine with patching it in chromium only.
> 
> Sure. I have sent a mail to the author as I couldn't find any 'How to submit a
> patch' link in the above URL for pyserial.

Thanks, I saw the email. Just ping this review if the author's response isn't
timely enough.

[vivekg, 2014-06-23 05:24:29]

On 2014/06/11 01:57:53, tonyg wrote:
> On 2014/06/10 03:55:32, vivekg_ wrote:
> > On 2014/06/09 16:04:50, tonyg wrote:
> > > This seems like a good change, but I'd prefer if we could make it upstream
> and
> > > then roll it into chromium. The code is here:
> > > http://sourceforge.net/projects/pyserial/ . Would you mind posting a patch
> > there
> > > to see if the author is responsive? If it takes more than a week to get a
> > > response, then I'd be fine with patching it in chromium only.
> > 
> > Sure. I have sent a mail to the author as I couldn't find any 'How to submit
a
> > patch' link in the above URL for pyserial.
> 
> Thanks, I saw the email. Just ping this review if the author's response isn't
> timely enough.

Haven't heard either in the mail or the patch raised. Should we land this
locally here?

[tonyg, 2014-06-23 16:46:31]

On 2014/06/09 05:58:48, vivekg_ wrote:
> Should we modify "src/tools/telemetry/third_party/pyserial/README.chromium" as
> well to include the description about changes by this CL?

Yes.

LGTM assuming you update that. I think we usually post the full diff in the
README.chromium.

[vivekg, 2014-06-24 04:07:15]

On 2014/06/23 at 16:46:31, tonyg wrote:
> On 2014/06/09 05:58:48, vivekg_ wrote:
> > Should we modify "src/tools/telemetry/third_party/pyserial/README.chromium"
as
> > well to include the description about changes by this CL?
> 
> Yes.
> 
> LGTM assuming you update that. I think we usually post the full diff in the
README.chromium.

@tonyg: Done. Can you please rubberstamp it again before we land it?

[tonyg, 2014-06-24 04:41:41]

lgtm

[tonyg, 2014-06-24 04:41:45]

The CQ bit was checked by tonyg@chromium.org

[commit-bot: I haz the power, 2014-06-24 04:42:51]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/325663002/20001

[commit-bot: I haz the power, 2014-06-24 08:19:32]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[commit-bot: I haz the power, 2014-06-24 08:51:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-24 08:51:32]

Try jobs failed on following builders:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[vivekg, 2014-06-24 08:53:23]

The CQ bit was checked by vivekg@chromium.org

[commit-bot: I haz the power, 2014-06-24 08:54:07]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/325663002/20001

[commit-bot: I haz the power, 2014-06-24 09:28:42]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_gpu_triggered_tests on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered...)

[vivekg, 2014-06-24 09:33:47]

The CQ bit was unchecked by vivekg@chromium.org

[vivekg, 2014-06-24 09:33:53]

The CQ bit was checked by vivekg@chromium.org

[commit-bot: I haz the power, 2014-06-24 09:34:26]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/325663002/20001

[commit-bot: I haz the power, 2014-06-24 09:35:55]

Change committed as 279368