Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1259)

Unified Diff: chrome/browser/ui/webui/options/browser_options_handler.cc

Issue 325633003: Add confirmation dialog when enabling a 3rd party IME. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix nits. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/browser_options_handler.cc
diff --git a/chrome/browser/ui/webui/options/browser_options_handler.cc b/chrome/browser/ui/webui/options/browser_options_handler.cc
index a12487eebdf7c2e57a4e762e74d7b4a17a5d1f12..6f0b1dc1289682c3b38358476e8d46e3844d9192 100644
--- a/chrome/browser/ui/webui/options/browser_options_handler.cc
+++ b/chrome/browser/ui/webui/options/browser_options_handler.cc
@@ -413,6 +413,10 @@ void BrowserOptionsHandler::GetLocalizedValues(base::DictionaryValue* values) {
{ "securityTitle", IDS_OPTIONS_SECURITY_SECTION_TITLE },
{ "syncOverview", IDS_SYNC_OVERVIEW },
{ "syncButtonTextStart", IDS_SYNC_SETUP_BUTTON_LABEL },
+ { "thirdPartyImeConfirmEnable", IDS_OK },
+ { "thirdPartyImeConfirmDisable", IDS_CANCEL },
+ { "thirdPartyImeConfirmMessage",
+ IDS_OPTIONS_SETTINGS_LANGUAGES_THIRD_PARTY_WARNING_MESSAGE },
{ "timezone", IDS_OPTIONS_SETTINGS_TIMEZONE_DESCRIPTION },
{ "use24HourClock", IDS_OPTIONS_SETTINGS_USE_24HOUR_CLOCK_DESCRIPTION },
#else
@@ -602,6 +606,9 @@ void BrowserOptionsHandler::GetLocalizedValues(base::DictionaryValue* values) {
"consumerManagementEnabled",
CommandLine::ForCurrentProcess()->HasSwitch(
chromeos::switches::kEnableConsumerManagement));
+
+ RegisterTitle(values, "thirdPartyImeConfirmOverlay",
+ IDS_OPTIONS_SETTINGS_LANGUAGES_THIRD_PARTY_WARNING_TITLE);
#endif
}

Powered by Google App Engine
This is Rietveld 408576698