Add confirmation dialog when enabling a 3rd party IME.

chrome/browser/resources/options/language_options.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // TODO(kochi): Generalize the notification as a component and put it
 // in js/cr/ui/notification.js .
 
 cr.define('options', function() {
   /** @const */ var OptionsPage = options.OptionsPage;
   /** @const */ var LanguageList = options.LanguageList;
+  /** @const */ var ThirdPartyImeConfirmOverlay =
+      options.ThirdPartyImeConfirmOverlay;
 
   /**
    * Spell check dictionary download status.
    * @type {Enum}
    */
   /** @const*/ var DOWNLOAD_STATUS = {
     IN_PROGRESS: 1,
     FAILED: 2
   };
 
@@ skipping 290 matching lines @@
       var inputMethodTemplate = $('language-options-input-method-template');
 
       for (var i = 0; i < inputMethods.length; i++) {
         var inputMethod = inputMethods[i];
         var element = inputMethodTemplate.cloneNode(true);
         element.id = '';
         element.languageCodeSet = inputMethod.languageCodeSet;
 
         var input = element.querySelector('input');
         input.inputMethodId = inputMethod.id;
+        input.imeProvider = inputMethod.extensionName;
         var span = element.querySelector('span');
         span.textContent = inputMethod.displayName;
 
         if (inputMethod.optionsPage) {
           var button = document.createElement('button');
           button.textContent = loadTimeData.getString('configure');
           button.inputMethodId = inputMethod.id;
           button.onclick = function(inputMethodId, e) {
             chrome.send('inputMethodOptionsOpen', [inputMethodId]);
           }.bind(this, inputMethod.id);
@@ skipping 485 matching lines @@
     },
 
     /**
      * Handles input method checkbox's click event.
      * @param {Event} e Click event.
      * @private
      */
     handleCheckboxClick_: function(e) {
       var checkbox = e.target;
 
+      // Third party IMEs require additional confirmation prior to enabling due
+      // to privacy risk.
+      if (!!checkbox.imeProvider && checkbox.checked) {

[Dan Beam, 2014/06/09 21:37:36]

you don't need the !!

[Shu Chen, 2014/06/10 01:02:18]

I think it would be safer to check IME ID instead of imeProvider to show the
warning dialog.

Please use /^_ext_ime_/.test(checkbox.inputMethodId).

[kevers, 2014/06/10 17:56:44]

Done.

+        var self = this;
+        var confirmationCallback = function() {
+          self.handleCheckboxUpdate_(checkbox);
+        };

[Dan Beam, 2014/06/09 21:37:36]

nit: var confirmationCallback = this.handleCheckboxUpdate_.bind(this, checkbox);

[kevers, 2014/06/10 17:56:44]

Done.

+        var cancellationCallback = function() {
+          checkbox.checked = false;
+        }

[Dan Beam, 2014/06/09 21:37:36]

};

[kevers, 2014/06/10 17:56:44]

Done.

+        ThirdPartyImeConfirmOverlay.showConfirmationDialog({
+          extension: checkbox.imeProvider,
+          confirm: confirmationCallback,
+          cancel: cancellationCallback
+        });
+      } else {
+        this.handleCheckboxUpdate_(checkbox);
+      }
+    },
+
+    /**
+     * Updates active IMEs based on change in state of a checkbox for an input
+     * method.
+     * @param {!Element} checkbox Updated checkbox element.
+     * @private
+     */
+    handleCheckboxUpdate_: function(checkbox) {
       if (checkbox.inputMethodId.match(/^_ext_ime_/)) {
         this.updateEnabledExtensionsFromCheckboxes_();
         this.saveEnabledExtensionPref_();
         return;
       }
       if (this.preloadEngines_.length == 1 && !checkbox.checked) {
         // Don't allow disabling the last input method.
         this.showNotification_(
             loadTimeData.getString('pleaseAddAnotherInputMethod'),
             loadTimeData.getString('okButton'));
@@ skipping 492 matching lines @@
 
   LanguageOptions.onComponentManagerInitialized = function(componentImes) {
     LanguageOptions.getInstance().appendComponentExtensionIme_(componentImes);
   };
 
   // Export
   return {
     LanguageOptions: LanguageOptions
   };
 });