Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 325573002: Oilpan: fix build after r175732. (Closed)

Created:
6 years, 6 months ago by sof
Modified:
6 years, 6 months ago
Reviewers:
haraken, oilpan-reviews
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Oilpan: fix build after r175732. Restore equality test back to being between Node* and a RawPtr<Node>, for which there is an implicit conversion from a RawPtr<Node> to a Node*. i.e., a RawPtr<Node> cannot be implicitly converted to a Node& (and vice versa.) TBR=haraken@chromium.org,oilpan-reviews@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175745

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/core/dom/ContainerNode.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
sof
Please take a look.
6 years, 6 months ago (2014-06-07 15:31:46 UTC) #1
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 6 months ago (2014-06-07 15:31:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/325573002/1
6 years, 6 months ago (2014-06-07 15:32:49 UTC) #3
commit-bot: I haz the power
Change committed as 175745
6 years, 6 months ago (2014-06-07 15:33:07 UTC) #4
haraken
6 years, 6 months ago (2014-06-07 16:31:33 UTC) #5
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698