--verify-predictable mode added for ensuring that GC behaves deterministically.

src/spaces.cc

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/v8.h"
 
 #include "src/full-codegen.h"
 #include "src/macro-assembler.h"
 #include "src/mark-compact.h"
 #include "src/msan.h"
@@ skipping 2879 matching lines @@
 
   if (Heap::ShouldZapGarbage()) {
     // Make the object consistent so the heap can be verified in OldSpaceStep.
     // We only need to do this in debug builds or if verify_heap is on.
     reinterpret_cast<Object**>(object->address())[0] =
         heap()->fixed_array_map();
     reinterpret_cast<Object**>(object->address())[1] = Smi::FromInt(0);
   }
 
   heap()->incremental_marking()->OldSpaceStep(object_size);
+  if (FLAG_allocations_digest) {
+    heap()->OnAllocationEvent(object, object_size);

[Hannes Payer (out of office), 2014/06/09 15:23:51]

The event call should be in Heap::AllocateRaw. There is actually already a call
to profiler->AllocationEvent. This is catching the same event for a different
purpose. I guess we can refactor there.

[Igor Sheludko, 2014/06/10 08:22:54]

I trigger "allocation event" each time any allocation happens (either object or
target place for evacuation), while profiler has to distinguish between new
object creation and object relocation. I think that for this verification
purpose we can keep things simple. WDYT?

[Hannes Payer (out of office), 2014/06/10 16:58:59]

1) Please move your monitoring code into Heap:AllocateRaw. That is our runtime
allocation choke point.
2) I would assume that it your monitoring call will be at the exact same
location as profiler->AllocationEvent. Hence, re-using this infrastructure would
keep stuff simple.
WDYT?

+  }
   return object;
 }
 
 
 size_t LargeObjectSpace::CommittedPhysicalMemory() {
   if (!VirtualMemory::HasLazyCommits()) return CommittedMemory();
   size_t size = 0;
   LargePage* current = first_page_;
   while (current != NULL) {
     size += current->CommittedPhysicalMemory();
@@ skipping 203 matching lines @@
     object->ShortPrint();
     PrintF("\n");
   }
   printf(" --------------------------------------\n");
   printf(" Marked: %x, LiveCount: %x\n", mark_size, LiveBytes());
 }
 
 #endif  // DEBUG
 
 } }  // namespace v8::internal