Issue 325513002: Revert 175508 "Eliminate MediaPlayer & MediaPlayerClient abstrac..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 325513002: Revert 175508 "Eliminate MediaPlayer & MediaPlayerClient abstrac..." (Closed)

Created:
6 years, 6 months ago by acolwell GONE FROM CHROMIUM

Modified:
6 years, 6 months ago

Reviewers:
Srirama

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/

Visibility:
Public.

More Reviews

Description

Revert 175508 "Eliminate MediaPlayer & MediaPlayerClient abstrac..." > Eliminate MediaPlayer & MediaPlayerClient abstractions(play/pause, other APIs) > > BUG=350571 > > Review URL: https://codereview.chromium.org/298093004 TBR=srirama.m@samsung.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175713

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+72 lines, -13 lines)			Patch
M	trunk/Source/core/html/HTMLMediaElement.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/Source/core/html/HTMLMediaElement.cpp	View	7 chunks	+12 lines, -12 lines	0 comments	Download
M	trunk/Source/platform/graphics/media/MediaPlayer.h	View	3 chunks	+13 lines, -0 lines	0 comments	Download
M	trunk/Source/web/WebMediaPlayerClientImpl.h	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	trunk/Source/web/WebMediaPlayerClientImpl.cpp	View	3 chunks	+40 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

acolwell GONE FROM CHROMIUM

Committed patchset #1 manually as r175713.

6 years, 6 months ago (2014-06-06 22:40:04 UTC) #2

acolwell GONE FROM CHROMIUM

FTR this was reverted in response to multiple crash bugs (Bug 381556, Bug 381570, Bug ...

6 years, 6 months ago (2014-06-06 22:53:36 UTC) #3

Srirama

6 years, 6 months ago (2014-06-08 07:36:39 UTC) #4

Message was sent while issue was closed.

On 2014/06/06 22:53:36, acolwell wrote:
> FTR this was reverted in response to multiple crash bugs (Bug 381556, Bug
> 381570, Bug 381825). It appears that it is actually possible for
> webMediaPlayer() to be null when m_readyState >= HAVE_METADATA, but none of
our
> tests caught it.

Changes are fine.

Expand Messages | Collapse Messages