Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 325503002: Some files don't need net/tools/epoll_server/epoll_server.h at all. (Closed)

Created:
6 years, 6 months ago by wtc
Modified:
6 years, 6 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, mmenke
Visibility:
Public.

Description

Some files don't need net/tools/epoll_server/epoll_server.h at all. Some files just need a forward declaration of EpollServer. R=rch@chromium.org,rtenneti@chromium.org BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275649

Patch Set 1 #

Patch Set 2 : Remove unrelated changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M net/tools/quic/quic_dispatcher.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/tools/quic/quic_dispatcher.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/tools/quic/quic_server_session_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/tools/quic/quic_spdy_client_stream_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/tools/quic/quic_time_wait_list_manager.h View 1 chunk +3 lines, -1 line 0 comments Download
M net/tools/quic/quic_time_wait_list_manager.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
wtc
6 years, 6 months ago (2014-06-06 22:14:12 UTC) #1
Ryan Hamilton
LGTM. Please make this same changes to the internal version (if they've not already been ...
6 years, 6 months ago (2014-06-06 22:26:05 UTC) #2
ramant (doing other things)
lgtm Thanks for doing this.
6 years, 6 months ago (2014-06-06 22:32:42 UTC) #3
wtc
On 2014/06/06 22:26:05, Ryan Hamilton wrote: > LGTM. Please make this same changes to the ...
6 years, 6 months ago (2014-06-06 22:40:54 UTC) #4
wtc
The CQ bit was checked by wtc@chromium.org
6 years, 6 months ago (2014-06-06 22:40:58 UTC) #5
ramant (doing other things)
6 years, 6 months ago (2014-06-06 22:41:54 UTC) #6
ramant (doing other things)
On 2014/06/06 22:40:54, wtc wrote: > On 2014/06/06 22:26:05, Ryan Hamilton wrote: > > LGTM. ...
6 years, 6 months ago (2014-06-06 22:42:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wtc@chromium.org/325503002/20001
6 years, 6 months ago (2014-06-06 22:42:53 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-07 03:49:10 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-07 08:37:50 UTC) #10
Message was sent while issue was closed.
Change committed as 275649

Powered by Google App Engine
This is Rietveld 408576698