Remove unused Views Translate InfoBar code.

Remove unused Views Translate InfoBar code.

The new translate UX uses bubbles instead of infobars.
Views uses the new UX by default, Mac will soon too.
(IDRs x-plat API should be removed after Mac switches)

Remove code unused since r248162 (4 months ago).
Stub out ChromeTranslateClient::CreateInfoBar for Views.

This should simplify Elliot's WIP MenuButton CL:
https://codereview.chromium.org/298813002
(these applied TextButtonBorders to MenuButtons instances)

BUG=276181, 288554, 241691, 383235, 155363
TEST=No Translate behavior changes; no complaints.
R=sky@chromium.org,pkasting@chromium.org,toyoshim@chromium.org
TBR=hajimehoshi@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276567

[msw, 2014-06-06 23:20:31]

Hey Scott, please take a look; thanks!

[tfarina, 2014-06-06 23:22:14]

Peter is already in the CC list, I was going to copy him. ;)

+David, in case he cares.

[droger, 2014-06-07 06:55:42]

On 2014/06/06 23:22:14, tfarina wrote:
> +David, in case he cares.

Yes, I care, thanks for the heads up!
This change should be fine for iOS in particular.

[Peter Kasting, 2014-06-09 00:27:22]

My only concern is that, last time I looked at this, it was still possible to
get the infobar UI on views if e.g. certain command-line switches were thrown,
or whatever.  I'd rather land this change only if the code is truly 100% dead in
all circumstances.

If it is, then LGTM.

https://codereview.chromium.org/325483003/diff/1/chrome/browser/translate/chr...
File chrome/browser/translate/chrome_translate_client.h (right):

https://codereview.chromium.org/325483003/diff/1/chrome/browser/translate/chr...
chrome/browser/translate/chrome_translate_client.h:13: #include
"components/infobars/core/infobar.h"
Curious why this was needed in the .h?

[msw, 2014-06-09 16:27:32]

On 2014/06/09 00:27:22, Peter Kasting wrote:
> My only concern is that, last time I looked at this, it was still possible to
> get the infobar UI on views if e.g. certain command-line switches were thrown,
> or whatever.  I'd rather land this change only if the code is truly 100% dead
in
> all circumstances.

The runtime flag is only available on Mac, and my second patch set removes the
*test-only* access to toggle back to the old infobar on other desktop platforms.

https://codereview.chromium.org/325483003/diff/1/chrome/browser/translate/chr...
File chrome/browser/translate/chrome_translate_client.h (right):

https://codereview.chromium.org/325483003/diff/1/chrome/browser/translate/chr...
chrome/browser/translate/chrome_translate_client.h:13: #include
"components/infobars/core/infobar.h"
On 2014/06/09 00:27:21, Peter Kasting wrote:
> Curious why this was needed in the .h?

Moved this to the .cc

[msw, 2014-06-09 22:48:41]

Scott, please take a look as you have time. CC'ing a couple others OWNERS that
might be concerned about the seemingly low relative test coverage of the new
bubble UX.

[sky, 2014-06-10 13:29:45]

LGTM - but wait for the guys in Japan to sign off on the removal.

[msw, 2014-06-10 17:00:40]

toyoshim@, can you take a look, or should we wait for hajimehoshi@ to return?

[Takashi Toyoshima, 2014-06-11 04:54:33]

https://codereview.chromium.org/325483003/diff/60001/chrome/browser/policy/po...
File chrome/browser/policy/policy_browsertest.cc (right):

https://codereview.chromium.org/325483003/diff/60001/chrome/browser/policy/po...
chrome/browser/policy/policy_browsertest.cc:1910: // Verify that the translate
infobar showed up.
This test has been disabled because it was flaky, but this change will
completely break the test because I do not think infobar_count() goes to 1u if
the infobar mode is not enabled.

Maybe we should let the owner of this test know that infobar counts can not be
available for checking if policy works on translate feature.
joaodasilva@ at http://crbug.com/241691?

https://codereview.chromium.org/325483003/diff/60001/chrome/browser/translate...
File chrome/browser/translate/translate_browsertest.cc (right):

https://codereview.chromium.org/325483003/diff/60001/chrome/browser/translate...
chrome/browser/translate/translate_browsertest.cc:126: // This test only applies
to the infobar translate UX, not the new bubble UX.
IIUC, with this change, these tests are changed to run only on mac, right?
These tests should not be just skipped for other platforms. We need to consider
tests for same cases with bubble UI. If you want to remove infobar code just
now, can you file a bug and add TODO to make them work again?

[msw, 2014-06-11 07:31:20]

Please take another look, thanks.

https://codereview.chromium.org/325483003/diff/60001/chrome/browser/policy/po...
File chrome/browser/policy/policy_browsertest.cc (right):

https://codereview.chromium.org/325483003/diff/60001/chrome/browser/policy/po...
chrome/browser/policy/policy_browsertest.cc:1910: // Verify that the translate
infobar showed up.
On 2014/06/11 04:54:32, Takashi Toyoshima (chromium) wrote:
> This test has been disabled because it was flaky, but this change will
> completely break the test because I do not think infobar_count() goes to 1u if
> the infobar mode is not enabled.
> 
> Maybe we should let the owner of this test know that infobar counts can not be
> available for checking if policy works on translate feature.
> joaodasilva@ at http://crbug.com/241691

Yeah, this also depends on the old infobar UI that is disabled and inaccessible
in production. I filed http://crbug.com/383235 to fix the tests for the new UX,
added another early return for this test, CC'ed joaodasilva, and added
BUG=241691,383235.

https://codereview.chromium.org/325483003/diff/60001/chrome/browser/translate...
File chrome/browser/translate/translate_browsertest.cc (right):

https://codereview.chromium.org/325483003/diff/60001/chrome/browser/translate...
chrome/browser/translate/translate_browsertest.cc:126: // This test only applies
to the infobar translate UX, not the new bubble UX.
On 2014/06/11 04:54:32, Takashi Toyoshima (chromium) wrote:
> IIUC, with this change, these tests are changed to run only on mac, right?
> These tests should not be just skipped for other platforms. We need to
consider
> tests for same cases with bubble UI. If you want to remove infobar code just
> now, can you file a bug and add TODO to make them work again?

I filed Issue 383235 and added TODOs. Most of these tests should be
infobar/bubble agnostic, and actual UX tests should be ported for the bubble
translate UX. There's not much point in testing disabled Views infobar UX
though, and the already incomplete testing probably shouldn't block removal of
otherwise unused code. I might be able to help cleanup the tests sometime.

Lmk if you prefer keeping some dead code around for testing. Perhaps I can
stub/remove more limited Views infobar code that we don't wish to continue
supporting (like custom TextButtonBorders for the info MenuButton instances).

[Takashi Toyoshima, 2014-06-11 09:14:32]

lgtm

https://codereview.chromium.org/325483003/diff/80001/chrome/browser/translate...
File chrome/browser/translate/translate_manager_render_view_host_unittest.cc
(right):

https://codereview.chromium.org/325483003/diff/80001/chrome/browser/translate...
chrome/browser/translate/translate_manager_render_view_host_unittest.cc:404: //
See BubbleNormalTranslate for corresponding bubble UX testing.
Thank you for checking each test case carefully!!

[msw, 2014-06-11 09:32:34]

The CQ bit was checked by msw@chromium.org

[commit-bot: I haz the power, 2014-06-11 09:35:37]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/msw@chromium.org/325483003/80001

[commit-bot: I haz the power, 2014-06-11 13:29:08]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/19...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-06-11 13:33:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-11 13:33:18]

Try jobs failed on following builders:
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/19...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[msw, 2014-06-11 16:56:39]

The CQ bit was checked by msw@chromium.org

[commit-bot: I haz the power, 2014-06-11 17:00:17]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/msw@chromium.org/325483003/100001

[commit-bot: I haz the power, 2014-06-11 21:24:27]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-06-11 21:31:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-11 21:31:10]

Try jobs failed on following builders:
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[msw, 2014-06-11 21:33:15]

The CQ bit was checked by msw@chromium.org

[commit-bot: I haz the power, 2014-06-11 21:34:24]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/msw@chromium.org/325483003/100001

[commit-bot: I haz the power, 2014-06-11 21:42:41]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-06-11 21:54:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-11 21:54:17]

Try jobs failed on following builders:
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[msw, 2014-06-12 03:32:54]

The CQ bit was checked by msw@chromium.org

[commit-bot: I haz the power, 2014-06-12 03:36:34]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/msw@chromium.org/325483003/100001

[commit-bot: I haz the power, 2014-06-12 07:42:27]

Change committed as 276567