Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 325473003: Fix Tools/Scripts/check-blink-deps (Closed)

Created:
6 years, 6 months ago by Julien - ping for review
Modified:
6 years, 6 months ago
CC:
blink-reviews
Visibility:
Public.

Description

Fix Tools/Scripts/check-blink-deps Chromium's checkdeps.py has moved but the script was never updated. TEST=Manually run the script and it works! Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175733

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Tools/Scripts/check-blink-deps View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Julien - ping for review
Trivial script fix that I found while tinkering with DEPS.
6 years, 6 months ago (2014-06-07 00:14:41 UTC) #1
Dirk Pranke
lgtm
6 years, 6 months ago (2014-06-07 00:21:49 UTC) #2
Julien - ping for review
The CQ bit was checked by jchaffraix@chromium.org
6 years, 6 months ago (2014-06-07 00:31:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/325473003/1
6 years, 6 months ago (2014-06-07 00:32:05 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-07 01:16:34 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-07 03:54:48 UTC) #6
Message was sent while issue was closed.
Change committed as 175733

Powered by Google App Engine
This is Rietveld 408576698