Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Unified Diff: chrome/browser/autocomplete/autocomplete_browsertest.cc

Issue 325443002: Move about://-related constants from //content to //url (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Android ifx Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/autocomplete_browsertest.cc
diff --git a/chrome/browser/autocomplete/autocomplete_browsertest.cc b/chrome/browser/autocomplete/autocomplete_browsertest.cc
index 3246da59e802f11be4800e6c55811fe500391db8..77fd3c59a899e83fa38a4d50860c4d0df9619aaa 100644
--- a/chrome/browser/autocomplete/autocomplete_browsertest.cc
+++ b/chrome/browser/autocomplete/autocomplete_browsertest.cc
@@ -78,16 +78,14 @@ IN_PROC_BROWSER_TEST_F(AutocompleteBrowserTest, Basic) {
OmniboxView* omnibox_view = location_bar->GetOmniboxView();
EXPECT_FALSE(location_bar->GetDestinationURL().is_valid());
- EXPECT_EQ(base::UTF8ToUTF16(content::kAboutBlankURL),
- omnibox_view->GetText());
+ EXPECT_EQ(base::UTF8ToUTF16(url::kAboutBlankURL), omnibox_view->GetText());
// TODO(phajdan.jr): check state of IsSelectAll when it's consistent across
// platforms.
location_bar->FocusLocation(true);
EXPECT_FALSE(location_bar->GetDestinationURL().is_valid());
- EXPECT_EQ(base::UTF8ToUTF16(content::kAboutBlankURL),
- omnibox_view->GetText());
+ EXPECT_EQ(base::UTF8ToUTF16(url::kAboutBlankURL), omnibox_view->GetText());
EXPECT_TRUE(omnibox_view->IsSelectAll());
omnibox_view->SetUserText(base::ASCIIToUTF16("chrome"));
@@ -99,16 +97,14 @@ IN_PROC_BROWSER_TEST_F(AutocompleteBrowserTest, Basic) {
omnibox_view->RevertAll();
EXPECT_FALSE(location_bar->GetDestinationURL().is_valid());
- EXPECT_EQ(base::UTF8ToUTF16(content::kAboutBlankURL),
- omnibox_view->GetText());
+ EXPECT_EQ(base::UTF8ToUTF16(url::kAboutBlankURL), omnibox_view->GetText());
EXPECT_FALSE(omnibox_view->IsSelectAll());
omnibox_view->SetUserText(base::ASCIIToUTF16("chrome"));
location_bar->Revert();
EXPECT_FALSE(location_bar->GetDestinationURL().is_valid());
- EXPECT_EQ(base::UTF8ToUTF16(content::kAboutBlankURL),
- omnibox_view->GetText());
+ EXPECT_EQ(base::UTF8ToUTF16(url::kAboutBlankURL), omnibox_view->GetText());
EXPECT_FALSE(omnibox_view->IsSelectAll());
}
@@ -161,8 +157,7 @@ IN_PROC_BROWSER_TEST_F(AutocompleteBrowserTest, MAYBE_Autocomplete) {
{
location_bar->Revert();
EXPECT_FALSE(location_bar->GetDestinationURL().is_valid());
- EXPECT_EQ(base::UTF8ToUTF16(content::kAboutBlankURL),
- omnibox_view->GetText());
+ EXPECT_EQ(base::UTF8ToUTF16(url::kAboutBlankURL), omnibox_view->GetText());
EXPECT_FALSE(omnibox_view->IsSelectAll());
const AutocompleteResult& result = autocomplete_controller->result();
EXPECT_TRUE(result.empty()) << AutocompleteResultAsString(result);
@@ -182,20 +177,18 @@ IN_PROC_BROWSER_TEST_F(AutocompleteBrowserTest, TabAwayRevertSelect) {
// and select all.
LocationBar* location_bar = GetLocationBar();
OmniboxView* omnibox_view = location_bar->GetOmniboxView();
- EXPECT_EQ(base::UTF8ToUTF16(content::kAboutBlankURL),
- omnibox_view->GetText());
+ EXPECT_EQ(base::UTF8ToUTF16(url::kAboutBlankURL), omnibox_view->GetText());
omnibox_view->SetUserText(base::string16());
content::WindowedNotificationObserver observer(
content::NOTIFICATION_LOAD_STOP,
content::NotificationService::AllSources());
- chrome::AddSelectedTabWithURL(browser(), GURL(content::kAboutBlankURL),
+ chrome::AddSelectedTabWithURL(browser(),
+ GURL(url::kAboutBlankURL),
content::PAGE_TRANSITION_AUTO_TOPLEVEL);
observer.Wait();
- EXPECT_EQ(base::UTF8ToUTF16(content::kAboutBlankURL),
- omnibox_view->GetText());
+ EXPECT_EQ(base::UTF8ToUTF16(url::kAboutBlankURL), omnibox_view->GetText());
chrome::CloseTab(browser());
- EXPECT_EQ(base::UTF8ToUTF16(content::kAboutBlankURL),
- omnibox_view->GetText());
+ EXPECT_EQ(base::UTF8ToUTF16(url::kAboutBlankURL), omnibox_view->GetText());
EXPECT_TRUE(omnibox_view->IsSelectAll());
}
@@ -213,8 +206,7 @@ IN_PROC_BROWSER_TEST_F(AutocompleteBrowserTest, FocusSearch) {
// Focus search when omnibox is blank
{
EXPECT_FALSE(location_bar->GetDestinationURL().is_valid());
- EXPECT_EQ(base::UTF8ToUTF16(content::kAboutBlankURL),
- omnibox_view->GetText());
+ EXPECT_EQ(base::UTF8ToUTF16(url::kAboutBlankURL), omnibox_view->GetText());
location_bar->FocusSearch();
EXPECT_FALSE(location_bar->GetDestinationURL().is_valid());
« no previous file with comments | « chrome/browser/android/omnibox/autocomplete_controller_android.cc ('k') | chrome/browser/autocomplete/builtin_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698