Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Side by Side Diff: chrome/browser/autocomplete/builtin_provider_unittest.cc

Issue 325443002: Move about://-related constants from //content to //url (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Android ifx Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/autocomplete/builtin_provider.h" 5 #include "chrome/browser/autocomplete/builtin_provider.h"
6 6
7 #include "base/format_macros.h" 7 #include "base/format_macros.h"
8 #include "base/strings/stringprintf.h" 8 #include "base/strings/stringprintf.h"
9 #include "base/strings/utf_string_conversions.h" 9 #include "base/strings/utf_string_conversions.h"
10 #include "chrome/browser/autocomplete/autocomplete_input.h" 10 #include "chrome/browser/autocomplete/autocomplete_input.h"
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
53 } 53 }
54 54
55 private: 55 private:
56 scoped_refptr<BuiltinProvider> provider_; 56 scoped_refptr<BuiltinProvider> provider_;
57 57
58 DISALLOW_COPY_AND_ASSIGN(BuiltinProviderTest); 58 DISALLOW_COPY_AND_ASSIGN(BuiltinProviderTest);
59 }; 59 };
60 60
61 #if !defined(OS_ANDROID) 61 #if !defined(OS_ANDROID)
62 TEST_F(BuiltinProviderTest, TypingScheme) { 62 TEST_F(BuiltinProviderTest, TypingScheme) {
63 const base::string16 kAbout = ASCIIToUTF16(content::kAboutScheme); 63 const base::string16 kAbout = ASCIIToUTF16(url::kAboutScheme);
64 const base::string16 kChrome = ASCIIToUTF16(content::kChromeUIScheme); 64 const base::string16 kChrome = ASCIIToUTF16(content::kChromeUIScheme);
65 const base::string16 kSeparator1 = ASCIIToUTF16(":"); 65 const base::string16 kSeparator1 = ASCIIToUTF16(":");
66 const base::string16 kSeparator2 = ASCIIToUTF16(":/"); 66 const base::string16 kSeparator2 = ASCIIToUTF16(":/");
67 const base::string16 kSeparator3 = 67 const base::string16 kSeparator3 =
68 ASCIIToUTF16(url::kStandardSchemeSeparator); 68 ASCIIToUTF16(url::kStandardSchemeSeparator);
69 69
70 // These default URLs should correspond with those in BuiltinProvider::Start. 70 // These default URLs should correspond with those in BuiltinProvider::Start.
71 const GURL kURL1 = GURL(chrome::kChromeUIChromeURLsURL); 71 const GURL kURL1 = GURL(chrome::kChromeUIChromeURLsURL);
72 const GURL kURL2 = GURL(chrome::kChromeUISettingsURL); 72 const GURL kURL2 = GURL(chrome::kChromeUISettingsURL);
73 const GURL kURL3 = GURL(chrome::kChromeUIVersionURL); 73 const GURL kURL3 = GURL(chrome::kChromeUIVersionURL);
(...skipping 26 matching lines...) Expand all
100 {kChrome + kSeparator1, 3, {kURL1, kURL2, kURL3}}, 100 {kChrome + kSeparator1, 3, {kURL1, kURL2, kURL3}},
101 {kChrome + kSeparator2, 3, {kURL1, kURL2, kURL3}}, 101 {kChrome + kSeparator2, 3, {kURL1, kURL2, kURL3}},
102 {kChrome + kSeparator3, 3, {kURL1, kURL2, kURL3}}, 102 {kChrome + kSeparator3, 3, {kURL1, kURL2, kURL3}},
103 {ASCIIToUTF16("ChRoMe://"), 3, {kURL1, kURL2, kURL3}}, 103 {ASCIIToUTF16("ChRoMe://"), 3, {kURL1, kURL2, kURL3}},
104 }; 104 };
105 105
106 RunTest(typing_scheme_cases, arraysize(typing_scheme_cases)); 106 RunTest(typing_scheme_cases, arraysize(typing_scheme_cases));
107 } 107 }
108 #else // Android uses a subset of the URLs 108 #else // Android uses a subset of the URLs
109 TEST_F(BuiltinProviderTest, TypingScheme) { 109 TEST_F(BuiltinProviderTest, TypingScheme) {
110 const base::string16 kAbout = ASCIIToUTF16(content::kAboutScheme); 110 const base::string16 kAbout = ASCIIToUTF16(url::kAboutScheme);
111 const base::string16 kChrome = ASCIIToUTF16(content::kChromeUIScheme); 111 const base::string16 kChrome = ASCIIToUTF16(content::kChromeUIScheme);
112 const base::string16 kSeparator1 = ASCIIToUTF16(":"); 112 const base::string16 kSeparator1 = ASCIIToUTF16(":");
113 const base::string16 kSeparator2 = ASCIIToUTF16(":/"); 113 const base::string16 kSeparator2 = ASCIIToUTF16(":/");
114 const base::string16 kSeparator3 = 114 const base::string16 kSeparator3 =
115 ASCIIToUTF16(url::kStandardSchemeSeparator); 115 ASCIIToUTF16(url::kStandardSchemeSeparator);
116 116
117 // These default URLs should correspond with those in BuiltinProvider::Start. 117 // These default URLs should correspond with those in BuiltinProvider::Start.
118 const GURL kURL1 = GURL(chrome::kChromeUIChromeURLsURL); 118 const GURL kURL1 = GURL(chrome::kChromeUIChromeURLsURL);
119 const GURL kURL2 = GURL(chrome::kChromeUIVersionURL); 119 const GURL kURL2 = GURL(chrome::kChromeUIVersionURL);
120 120
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
165 {ASCIIToUTF16("scheme://"), 0, {}}, 165 {ASCIIToUTF16("scheme://"), 0, {}},
166 {ASCIIToUTF16("scheme://host"), 0, {}}, 166 {ASCIIToUTF16("scheme://host"), 0, {}},
167 {ASCIIToUTF16("scheme:host/path?query#ref"), 0, {}}, 167 {ASCIIToUTF16("scheme:host/path?query#ref"), 0, {}},
168 {ASCIIToUTF16("scheme://host/path?query#ref"), 0, {}}, 168 {ASCIIToUTF16("scheme://host/path?query#ref"), 0, {}},
169 }; 169 };
170 170
171 RunTest(non_chrome_url_cases, arraysize(non_chrome_url_cases)); 171 RunTest(non_chrome_url_cases, arraysize(non_chrome_url_cases));
172 } 172 }
173 173
174 TEST_F(BuiltinProviderTest, ChromeURLs) { 174 TEST_F(BuiltinProviderTest, ChromeURLs) {
175 const base::string16 kAbout = ASCIIToUTF16(content::kAboutScheme); 175 const base::string16 kAbout = ASCIIToUTF16(url::kAboutScheme);
176 const base::string16 kChrome = ASCIIToUTF16(content::kChromeUIScheme); 176 const base::string16 kChrome = ASCIIToUTF16(content::kChromeUIScheme);
177 const base::string16 kSeparator1 = ASCIIToUTF16(":"); 177 const base::string16 kSeparator1 = ASCIIToUTF16(":");
178 const base::string16 kSeparator2 = ASCIIToUTF16(":/"); 178 const base::string16 kSeparator2 = ASCIIToUTF16(":/");
179 const base::string16 kSeparator3 = 179 const base::string16 kSeparator3 =
180 ASCIIToUTF16(url::kStandardSchemeSeparator); 180 ASCIIToUTF16(url::kStandardSchemeSeparator);
181 181
182 // This makes assumptions about the chrome URLs listed by the BuiltinProvider. 182 // This makes assumptions about the chrome URLs listed by the BuiltinProvider.
183 // Currently they are derived from chrome::kChromeHostURLs[]. 183 // Currently they are derived from chrome::kChromeHostURLs[].
184 const base::string16 kHostM1 = 184 const base::string16 kHostM1 =
185 ASCIIToUTF16(content::kChromeUIMediaInternalsHost); 185 ASCIIToUTF16(content::kChromeUIMediaInternalsHost);
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
218 {kChrome + kSeparator3 + kHostM2.substr(0, 3), 2, {kURLM2, kURLM3}}, 218 {kChrome + kSeparator3 + kHostM2.substr(0, 3), 2, {kURLM2, kURLM3}},
219 {kChrome + kSeparator3 + kHostM1, 1, {kURLM1}}, 219 {kChrome + kSeparator3 + kHostM1, 1, {kURLM1}},
220 {kChrome + kSeparator2 + kHostM2, 2, {kURLM2, kURLM3}}, 220 {kChrome + kSeparator2 + kHostM2, 2, {kURLM2, kURLM3}},
221 {kChrome + kSeparator2 + kHostM3, 1, {kURLM3}}, 221 {kChrome + kSeparator2 + kHostM3, 1, {kURLM3}},
222 }; 222 };
223 223
224 RunTest(chrome_url_cases, arraysize(chrome_url_cases)); 224 RunTest(chrome_url_cases, arraysize(chrome_url_cases));
225 } 225 }
226 226
227 TEST_F(BuiltinProviderTest, AboutBlank) { 227 TEST_F(BuiltinProviderTest, AboutBlank) {
228 const base::string16 kAbout = ASCIIToUTF16(content::kAboutScheme); 228 const base::string16 kAbout = ASCIIToUTF16(url::kAboutScheme);
229 const base::string16 kChrome = ASCIIToUTF16(content::kChromeUIScheme); 229 const base::string16 kChrome = ASCIIToUTF16(content::kChromeUIScheme);
230 const base::string16 kAboutBlank = ASCIIToUTF16(content::kAboutBlankURL); 230 const base::string16 kAboutBlank = ASCIIToUTF16(url::kAboutBlankURL);
231 const base::string16 kBlank = ASCIIToUTF16("blank"); 231 const base::string16 kBlank = ASCIIToUTF16("blank");
232 const base::string16 kSeparator1 = 232 const base::string16 kSeparator1 =
233 ASCIIToUTF16(url::kStandardSchemeSeparator); 233 ASCIIToUTF16(url::kStandardSchemeSeparator);
234 const base::string16 kSeparator2 = ASCIIToUTF16(":///"); 234 const base::string16 kSeparator2 = ASCIIToUTF16(":///");
235 const base::string16 kSeparator3 = ASCIIToUTF16(";///"); 235 const base::string16 kSeparator3 = ASCIIToUTF16(";///");
236 236
237 const GURL kURLBlob = GURL(kChrome + kSeparator1 + 237 const GURL kURLBlob = GURL(kChrome + kSeparator1 +
238 ASCIIToUTF16(content::kChromeUIBlobInternalsHost)); 238 ASCIIToUTF16(content::kChromeUIBlobInternalsHost));
239 const GURL kURLBlank = GURL(kAboutBlank); 239 const GURL kURLBlank = GURL(kAboutBlank);
240 240
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
303 {kSettings + kPage1.substr(0, 1), 2, {kURL1, kURL2}}, 303 {kSettings + kPage1.substr(0, 1), 2, {kURL1, kURL2}},
304 {kSettings + kPage1.substr(0, 2), 1, {kURL1}}, 304 {kSettings + kPage1.substr(0, 2), 1, {kURL1}},
305 {kSettings + kPage1.substr(0, kPage1.length() - 1), 1, {kURL1}}, 305 {kSettings + kPage1.substr(0, kPage1.length() - 1), 1, {kURL1}},
306 {kSettings + kPage1, 1, {kURL1}}, 306 {kSettings + kPage1, 1, {kURL1}},
307 {kSettings + kPage2, 1, {kURL2}}, 307 {kSettings + kPage2, 1, {kURL2}},
308 }; 308 };
309 309
310 RunTest(settings_subpage_cases, arraysize(settings_subpage_cases)); 310 RunTest(settings_subpage_cases, arraysize(settings_subpage_cases));
311 } 311 }
312 #endif 312 #endif
OLDNEW
« no previous file with comments | « chrome/browser/autocomplete/builtin_provider.cc ('k') | chrome/browser/autofill/content_autofill_driver_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698