Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Side by Side Diff: chrome/browser/ui/browser_browsertest.cc

Issue 325443002: Move about://-related constants from //content to //url (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <string> 5 #include <string>
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/command_line.h" 8 #include "base/command_line.h"
9 #include "base/compiler_specific.h" 9 #include "base/compiler_specific.h"
10 #include "base/files/file_path.h" 10 #include "base/files/file_path.h"
(...skipping 1152 matching lines...) Expand 10 before | Expand all | Expand 10 after
1163 EXPECT_FALSE(command_updater->IsCommandEnabled(IDC_CREATE_SHORTCUTS)); 1163 EXPECT_FALSE(command_updater->IsCommandEnabled(IDC_CREATE_SHORTCUTS));
1164 1164
1165 GURL history_url(chrome::kChromeUIHistoryURL); 1165 GURL history_url(chrome::kChromeUIHistoryURL);
1166 ui_test_utils::NavigateToURL(browser(), history_url); 1166 ui_test_utils::NavigateToURL(browser(), history_url);
1167 EXPECT_FALSE(command_updater->IsCommandEnabled(IDC_CREATE_SHORTCUTS)); 1167 EXPECT_FALSE(command_updater->IsCommandEnabled(IDC_CREATE_SHORTCUTS));
1168 1168
1169 GURL downloads_url(chrome::kChromeUIDownloadsURL); 1169 GURL downloads_url(chrome::kChromeUIDownloadsURL);
1170 ui_test_utils::NavigateToURL(browser(), downloads_url); 1170 ui_test_utils::NavigateToURL(browser(), downloads_url);
1171 EXPECT_FALSE(command_updater->IsCommandEnabled(IDC_CREATE_SHORTCUTS)); 1171 EXPECT_FALSE(command_updater->IsCommandEnabled(IDC_CREATE_SHORTCUTS));
1172 1172
1173 GURL blank_url(content::kAboutBlankURL); 1173 GURL blank_url(url::kAboutBlankURL);
1174 ui_test_utils::NavigateToURL(browser(), blank_url); 1174 ui_test_utils::NavigateToURL(browser(), blank_url);
1175 EXPECT_FALSE(command_updater->IsCommandEnabled(IDC_CREATE_SHORTCUTS)); 1175 EXPECT_FALSE(command_updater->IsCommandEnabled(IDC_CREATE_SHORTCUTS));
1176 } 1176 }
1177 1177
1178 // Change a tab into an application window. 1178 // Change a tab into an application window.
1179 // DISABLED: http://crbug.com/72310 1179 // DISABLED: http://crbug.com/72310
1180 IN_PROC_BROWSER_TEST_F(BrowserTest, DISABLED_ConvertTabToAppShortcut) { 1180 IN_PROC_BROWSER_TEST_F(BrowserTest, DISABLED_ConvertTabToAppShortcut) {
1181 ASSERT_TRUE(test_server()->Start()); 1181 ASSERT_TRUE(test_server()->Start());
1182 GURL http_url(test_server()->GetURL(std::string())); 1182 GURL http_url(test_server()->GetURL(std::string()));
1183 ASSERT_TRUE(http_url.SchemeIs(url::kHttpScheme)); 1183 ASSERT_TRUE(http_url.SchemeIs(url::kHttpScheme));
(...skipping 290 matching lines...) Expand 10 before | Expand all | Expand 10 after
1474 model->AddWebContents(app_contents, 0, content::PageTransitionFromInt(0), 1474 model->AddWebContents(app_contents, 0, content::PageTransitionFromInt(0),
1475 TabStripModel::ADD_NONE); 1475 TabStripModel::ADD_NONE);
1476 model->SetTabPinned(0, true); 1476 model->SetTabPinned(0, true);
1477 ui_test_utils::NavigateToURL(browser(), url); 1477 ui_test_utils::NavigateToURL(browser(), url);
1478 1478
1479 // Add a non pinned tab. 1479 // Add a non pinned tab.
1480 chrome::NewTab(browser()); 1480 chrome::NewTab(browser());
1481 1481
1482 // Add a pinned non-app tab. 1482 // Add a pinned non-app tab.
1483 chrome::NewTab(browser()); 1483 chrome::NewTab(browser());
1484 ui_test_utils::NavigateToURL(browser(), GURL(content::kAboutBlankURL)); 1484 ui_test_utils::NavigateToURL(browser(), GURL(url::kAboutBlankURL));
1485 model->SetTabPinned(2, true); 1485 model->SetTabPinned(2, true);
1486 1486
1487 // Write out the pinned tabs. 1487 // Write out the pinned tabs.
1488 PinnedTabCodec::WritePinnedTabs(browser()->profile()); 1488 PinnedTabCodec::WritePinnedTabs(browser()->profile());
1489 1489
1490 // Simulate launching again. 1490 // Simulate launching again.
1491 CommandLine dummy(CommandLine::NO_PROGRAM); 1491 CommandLine dummy(CommandLine::NO_PROGRAM);
1492 chrome::startup::IsFirstRun first_run = first_run::IsChromeFirstRun() ? 1492 chrome::startup::IsFirstRun first_run = first_run::IsChromeFirstRun() ?
1493 chrome::startup::IS_FIRST_RUN : chrome::startup::IS_NOT_FIRST_RUN; 1493 chrome::startup::IS_FIRST_RUN : chrome::startup::IS_NOT_FIRST_RUN;
1494 StartupBrowserCreatorImpl launch(base::FilePath(), dummy, first_run); 1494 StartupBrowserCreatorImpl launch(base::FilePath(), dummy, first_run);
(...skipping 119 matching lines...) Expand 10 before | Expand all | Expand 10 after
1614 Browser::CreateParams params(types[i], browser()->profile(), 1614 Browser::CreateParams params(types[i], browser()->profile(),
1615 browser()->host_desktop_type()); 1615 browser()->host_desktop_type());
1616 params.initial_show_state = ui::SHOW_STATE_MINIMIZED; 1616 params.initial_show_state = ui::SHOW_STATE_MINIMIZED;
1617 AddBlankTabAndShow(new Browser(params)); 1617 AddBlankTabAndShow(new Browser(params));
1618 } 1618 }
1619 } 1619 }
1620 1620
1621 // Makes sure the forward button is disabled immediately when navigating 1621 // Makes sure the forward button is disabled immediately when navigating
1622 // forward to a slow-to-commit page. 1622 // forward to a slow-to-commit page.
1623 IN_PROC_BROWSER_TEST_F(BrowserTest, ForwardDisabledOnForward) { 1623 IN_PROC_BROWSER_TEST_F(BrowserTest, ForwardDisabledOnForward) {
1624 GURL blank_url(content::kAboutBlankURL); 1624 GURL blank_url(url::kAboutBlankURL);
1625 ui_test_utils::NavigateToURL(browser(), blank_url); 1625 ui_test_utils::NavigateToURL(browser(), blank_url);
1626 1626
1627 ui_test_utils::NavigateToURL( 1627 ui_test_utils::NavigateToURL(
1628 browser(), ui_test_utils::GetTestUrl( 1628 browser(), ui_test_utils::GetTestUrl(
1629 base::FilePath(base::FilePath::kCurrentDirectory), 1629 base::FilePath(base::FilePath::kCurrentDirectory),
1630 base::FilePath(kTitle1File))); 1630 base::FilePath(kTitle1File)));
1631 1631
1632 content::WindowedNotificationObserver back_nav_load_observer( 1632 content::WindowedNotificationObserver back_nav_load_observer(
1633 content::NOTIFICATION_LOAD_STOP, 1633 content::NOTIFICATION_LOAD_STOP,
1634 content::Source<NavigationController>( 1634 content::Source<NavigationController>(
(...skipping 439 matching lines...) Expand 10 before | Expand all | Expand 10 after
2074 // The normal browser should now have two. 2074 // The normal browser should now have two.
2075 EXPECT_EQ(2, browser()->tab_strip_model()->count()); 2075 EXPECT_EQ(2, browser()->tab_strip_model()->count());
2076 2076
2077 // Open an app frame browser with a single blank foreground tab. 2077 // Open an app frame browser with a single blank foreground tab.
2078 Browser* app_browser = new Browser(Browser::CreateParams::CreateForApp( 2078 Browser* app_browser = new Browser(Browser::CreateParams::CreateForApp(
2079 L"Test", browser()->profile(), false)); 2079 L"Test", browser()->profile(), false));
2080 chrome::AddTabAt(app_browser, GURL(), -1, true); 2080 chrome::AddTabAt(app_browser, GURL(), -1, true);
2081 EXPECT_EQ(1, app_browser->tab_strip_model()->count()); 2081 EXPECT_EQ(1, app_browser->tab_strip_model()->count());
2082 2082
2083 // Now try opening another tab in the app browser. 2083 // Now try opening another tab in the app browser.
2084 AddTabWithURLParams params2(GURL(content::kAboutBlankURL), 2084 AddTabWithURLParams params2(GURL(url::kAboutBlankURL),
2085 content::PAGE_TRANSITION_TYPED); 2085 content::PAGE_TRANSITION_TYPED);
2086 app_browser->AddTabWithURL(&params2); 2086 app_browser->AddTabWithURL(&params2);
2087 EXPECT_EQ(app_browser, params2.target); 2087 EXPECT_EQ(app_browser, params2.target);
2088 2088
2089 // The popup should still only have one tab. 2089 // The popup should still only have one tab.
2090 EXPECT_EQ(1, app_browser->tab_strip_model()->count()); 2090 EXPECT_EQ(1, app_browser->tab_strip_model()->count());
2091 2091
2092 // The normal browser should now have three. 2092 // The normal browser should now have three.
2093 EXPECT_EQ(3, browser()->tab_strip_model()->count()); 2093 EXPECT_EQ(3, browser()->tab_strip_model()->count());
2094 2094
2095 // Open an app frame popup browser with a single blank foreground tab. 2095 // Open an app frame popup browser with a single blank foreground tab.
2096 Browser* app_popup_browser = new Browser(Browser::CreateParams::CreateForApp( 2096 Browser* app_popup_browser = new Browser(Browser::CreateParams::CreateForApp(
2097 L"Test", browser()->profile(), false)); 2097 L"Test", browser()->profile(), false));
2098 chrome::AddTabAt(app_popup_browser, GURL(), -1, true); 2098 chrome::AddTabAt(app_popup_browser, GURL(), -1, true);
2099 EXPECT_EQ(1, app_popup_browser->tab_strip_model()->count()); 2099 EXPECT_EQ(1, app_popup_browser->tab_strip_model()->count());
2100 2100
2101 // Now try opening another tab in the app popup browser. 2101 // Now try opening another tab in the app popup browser.
2102 AddTabWithURLParams params3(GURL(content::kAboutBlankURL), 2102 AddTabWithURLParams params3(GURL(url::kAboutBlankURL),
2103 content::PAGE_TRANSITION_TYPED); 2103 content::PAGE_TRANSITION_TYPED);
2104 app_popup_browser->AddTabWithURL(&params3); 2104 app_popup_browser->AddTabWithURL(&params3);
2105 EXPECT_EQ(app_popup_browser, params3.target); 2105 EXPECT_EQ(app_popup_browser, params3.target);
2106 2106
2107 // The popup should still only have one tab. 2107 // The popup should still only have one tab.
2108 EXPECT_EQ(1, app_popup_browser->tab_strip_model()->count()); 2108 EXPECT_EQ(1, app_popup_browser->tab_strip_model()->count());
2109 2109
2110 // The normal browser should now have four. 2110 // The normal browser should now have four.
2111 EXPECT_EQ(4, browser()->tab_strip_model()->count()); 2111 EXPECT_EQ(4, browser()->tab_strip_model()->count());
2112 2112
(...skipping 573 matching lines...) Expand 10 before | Expand all | Expand 10 after
2686 #endif 2686 #endif
2687 EXPECT_EQ(exp_commit_size, rwhv_commit_size2); 2687 EXPECT_EQ(exp_commit_size, rwhv_commit_size2);
2688 EXPECT_EQ(exp_commit_size, wcv_commit_size2); 2688 EXPECT_EQ(exp_commit_size, wcv_commit_size2);
2689 gfx::Size exp_final_size(initial_wcv_size); 2689 gfx::Size exp_final_size(initial_wcv_size);
2690 exp_final_size.Enlarge(wcv_resize_insets.width(), 2690 exp_final_size.Enlarge(wcv_resize_insets.width(),
2691 wcv_resize_insets.height() + height_inset); 2691 wcv_resize_insets.height() + height_inset);
2692 EXPECT_EQ(exp_final_size, 2692 EXPECT_EQ(exp_final_size,
2693 web_contents->GetRenderWidgetHostView()->GetViewBounds().size()); 2693 web_contents->GetRenderWidgetHostView()->GetViewBounds().size());
2694 EXPECT_EQ(exp_final_size, web_contents->GetContainerBounds().size()); 2694 EXPECT_EQ(exp_final_size, web_contents->GetContainerBounds().size());
2695 } 2695 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698