Issue 325433002: Elevated install of recovery component (UI part).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 325433002: Elevated install of recovery component (UI part). (Closed)

Created:
6 years, 6 months ago by xiaoling

Modified:
6 years, 5 months ago

Reviewers:

CC:
chromium-reviews, tfarina, asvitkine+watch_chromium.org, jar+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Elevated install of recovery component when needed. This CL includes: (1) Updated upgrade detector to detect the pref flag set by the recovery component when elevation is needed. (2) Added RecoveryComponentBubbleView which is presented to user before UAC prompt. (3) Added command line argument to simulate elevation request from recovery component for testing purpose. BUG=381801

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Created: 6 years, 5 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9479 lines, -9059 lines)			Patch
M	chrome/app/chromium_strings.grd	View	1 2 3 4	1 chunk	+1290 lines, -1279 lines	0 comments	Download
M	chrome/app/google_chrome_strings.grd	View	1 2 3 4	1 chunk	+1215 lines, -1204 lines	0 comments	Download
M	chrome/browser/chrome_notification_types.h	View	1 2 3 4	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/component_updater/recovery_component_installer.h	View	1 2 3 4	2 chunks	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/component_updater/recovery_component_installer.cc	View	1 2 3 4	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/browser_commands.cc	View	1 2 3 4	1 chunk	+6 lines, -1 line	0 comments	Download
A	chrome/browser/ui/views/recovery_component_bubble_view.h	View	2 3 4	1 chunk	+69 lines, -0 lines	0 comments	Download
A	chrome/browser/ui/views/recovery_component_bubble_view.cc	View	1 2 3 4	1 chunk	+186 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/toolbar/toolbar_view.h	View	2 3 4	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/toolbar/toolbar_view.cc	View	1 2 3 4	4 chunks	+14 lines, -0 lines	0 comments	Download
M	chrome/browser/upgrade_detector.h	View	1 2 3 4	3 chunks	+11 lines, -0 lines	0 comments	Download
M	chrome/browser/upgrade_detector.cc	View	2 3 4	2 chunks	+9 lines, -1 line	0 comments	Download
M	chrome/browser/upgrade_detector_impl.h	View	1 2 3 4	3 chunks	+12 lines, -5 lines	0 comments	Download
M	chrome/browser/upgrade_detector_impl.cc	View	1 2 3 4	1 chunk	+539 lines, -499 lines	0 comments	Download
M	chrome/chrome_browser_ui.gypi	View	1 2 3 4	1 chunk	+2954 lines, -2952 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View	1 2 3 4	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/common/chrome_switches.cc	View	1 2 3 4	1 chunk	+7 lines, -4 lines	0 comments	Download
M	chrome/common/pref_names.h	View	1 2 3 4	1 chunk	+820 lines, -818 lines	0 comments	Download
M	chrome/common/pref_names.cc	View	1 2 3 4	1 chunk	+2299 lines, -2295 lines	0 comments	Download
M	tools/metrics/actions/actions.xml	View	1 2 3 4	1 chunk	+26 lines, -0 lines	0 comments	Download