Issue 32543006: Remove --enable-audible-notifications flag for feature launch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 32543006: Remove --enable-audible-notifications flag for feature launch. (Closed)

Created:
7 years, 2 months ago by miu

Modified:
7 years, 2 months ago

Reviewers:
DaleCurtis, Jói

CC:
chromium-reviews, fischman+watch_chromium.org, jam, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org, miu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove --enable-audible-notifications flag for feature launch. BUG=290550 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=230199

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -17 lines)			Patch
M	content/browser/renderer_host/media/audio_renderer_host.cc	View	3 chunks	+5 lines, -10 lines	0 comments	Download
M	content/public/common/content_switches.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/public/common/content_switches.cc	View	1 chunk	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

miu

dalecurtis: Please review. joi: OWNERS stamp for changes in content/public/common/content_switches.* With this change, the tab ...

7 years, 2 months ago (2013-10-22 00:52:26 UTC) #1

Jói

LGTM On Tue, Oct 22, 2013 at 12:55 AM, <dalecurtis@chromium.org> wrote: > lgtm! \o/ > ...

7 years, 2 months ago (2013-10-22 10:03:22 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miu@chromium.org/32543006/1

7 years, 2 months ago (2013-10-22 17:49:46 UTC) #4

Message was sent while issue was closed.

Change committed as 230199

Expand Messages | Collapse Messages