tools/skpdiff/SkPMetric.cpp - Issue 325413003: rebaseline_server: use just skpdiff, not Python Image Library

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/skpdiff/SkPMetric.cpp

Issue 325413003: rebaseline_server: use just skpdiff, not Python Image Library (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: attempt to fix "'abs' : ambiguous call to overloaded function" on Windows Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/skpdiff/SkPMetric.cpp

diff --git a/tools/skpdiff/SkPMetric.cpp b/tools/skpdiff/SkPMetric.cpp

index a433d9f4b30576b1298a0dbf5acc5514e5b81f0b..392a3422157ef99cda75b8104f7539662865c8a2 100644

--- a/tools/skpdiff/SkPMetric.cpp

+++ b/tools/skpdiff/SkPMetric.cpp

@@ -442,7 +442,8 @@ static double pmetric(const ImageLAB* baselineLAB, const ImageLAB* testLAB, int*

return 1.0 - (double)(*poiCount) / (width * height);

}

-bool SkPMetric::diff(SkBitmap* baseline, SkBitmap* test, bool computeMask, Result* result) const {

+bool SkPMetric::diff(SkBitmap* baseline, SkBitmap* test, const BitmapsToCreate& bitmapsToCreate,

+ Result* result) const {

double startTime = get_seconds();

// Ensure the images are comparable

« no previous file with comments | « tools/skpdiff/SkPMetric.h ('k') | tools/skpdiff/skpdiff_main.cpp » ('j') | no next file with comments »