tools/skpdiff/SkDifferentPixelsMetric.h - Issue 325413003: rebaseline_server: use just skpdiff, not Python Image Library

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/skpdiff/SkDifferentPixelsMetric.h

Issue 325413003: rebaseline_server: use just skpdiff, not Python Image Library (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/skpdiff/SkDifferentPixelsMetric.h

diff --git a/tools/skpdiff/SkDifferentPixelsMetric.h b/tools/skpdiff/SkDifferentPixelsMetric.h

index 06c56b1cca245bf6c86046530d2657ee45c80d73..dba6a9d8c75337346f3a285626f8053fd3f3eb93 100644

--- a/tools/skpdiff/SkDifferentPixelsMetric.h

+++ b/tools/skpdiff/SkDifferentPixelsMetric.h

@@ -28,8 +28,8 @@ class SkDifferentPixelsMetric :

#endif

public:

virtual const char* getName() const SK_OVERRIDE;

- virtual bool diff(SkBitmap* baseline, SkBitmap* test, bool computeMask,

- Result* result) const SK_OVERRIDE;

+ virtual bool diff(SkBitmap* baseline, SkBitmap* test, bool computeAlphaMask,

+ bool computeRgbDiff, bool computeWhiteDiff, Result* result) const SK_OVERRIDE;

protected:

#if SK_SUPPORT_OPENCL