Issue 325383002: Snapshot File metadata when serializing for IDB

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 325383002: Snapshot File metadata when serializing for IDB (Closed)

Created:
6 years, 6 months ago by ericu

Modified:
6 years, 6 months ago

Reviewers:
jsbell, abarth-chromium

CC:
abarth-chromium, alecflett, arv+blink, blink-reviews, blink-reviews-bindings_chromium.org, cmumford, dgrogan, ericu+idb_chromium.org, jsbell+idb_chromium.org, kinuko+fileapi, nhiroki, tzik

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Capture snapshots of File metadata whenever we send a File to IDB. This way if someone changes a File during a long, slow commit, we won't surprise the user by storing the new version. Also includes missing error-checking in a test that's sensitive to changes in this area. See https://codereview.chromium.org/333533002/ for the Chromium code that will check the metadata if you're curious. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176538

Patch Set 1 #

Patch Set 2 : Checkpointing work #

Patch Set 3 : Working #

Patch Set 4 : Minor cleanup #

Patch Set 5 : Fix test expectation. #

Patch Set 6 : Try a safer approach #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -4 lines)			Patch
	M	LayoutTests/storage/indexeddb/blob-basics-metadata.html	View	1 2 3 4 5	3 chunks	+4 lines, -0 lines	0 comments	Download
	M	Source/bindings/v8/SerializedScriptValue.cpp	View	1 2 3 4 5	3 chunks	+8 lines, -4 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

jsbell

lgtm (will need an OWNERS stamp for SerializedScriptValue)

6 years, 6 months ago (2014-06-19 16:08:54 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ericu@chromium.org/325383002/90001

6 years, 6 months ago (2014-06-19 18:42:46 UTC) #5

Message was sent while issue was closed.

Change committed as 176538

Expand Messages | Collapse Messages