Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 325373002: Use override consistently instead of virtual. (Closed)

Created:
6 years, 6 months ago by ramant (doing other things)
Modified:
6 years, 6 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Use override consistently instead of virtual. Merge internal change: 68717267 R=rch@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -17 lines) Patch
M net/quic/quic_packet_creator_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/quic_packet_generator_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/quic/quic_sent_packet_manager_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_session_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_stream_sequencer_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/reliable_quic_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/test_tools/crypto_test_utils_openssl.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/test_tools/simple_quic_framer.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_in_memory_cache_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_spdy_server_stream_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_time_wait_list_manager_test.cc View 4 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ramant (doing other things)
6 years, 6 months ago (2014-06-11 23:29:32 UTC) #1
Ryan Hamilton
6 years, 6 months ago (2014-06-12 00:42:00 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698