Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1179)

Issue 325323003: Blacklists virtualCamera.ax (Closed)

Created:
6 years, 6 months ago by henrika (OOO until Aug 14)
Modified:
6 years, 6 months ago
CC:
chromium-reviews, caitkp+watch_chromium.org, DaleCurtis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Blacklists virtualCamera.ax. Tries to avoid crash in media::CoreAudioUtil::CreateDeviceEnumerator by blacklisting a DLL which accounts for a large amount of crashes we see in CreateDeviceEnumerator. BUG=383715, 378465 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276946

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome_elf/blacklist/blacklist.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
henrika (OOO until Aug 14)
Tommi, adding one module here (not sure if .ax is OK). Dale suggests two more. ...
6 years, 6 months ago (2014-06-12 11:18:48 UTC) #1
henrika (OOO until Aug 14)
robertshield@: adding you as owner. Thanks!
6 years, 6 months ago (2014-06-12 11:25:18 UTC) #2
tommi (sloooow) - chröme
lgtm
6 years, 6 months ago (2014-06-12 11:28:14 UTC) #3
henrika (OOO until Aug 14)
robertshield@: if you are OK, please press the button, thx.
6 years, 6 months ago (2014-06-12 11:32:43 UTC) #4
robertshield
lgtm FYI csharp@, this is apparently blocking canary release due to high crash rate. Approving ...
6 years, 6 months ago (2014-06-12 23:37:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/henrika@chromium.org/325323003/1
6 years, 6 months ago (2014-06-12 23:40:15 UTC) #6
commit-bot: I haz the power
Change committed as 276946
6 years, 6 months ago (2014-06-13 06:47:56 UTC) #7
henrika (OOO until Aug 14)
On 2014/06/12 23:37:31, robertshield wrote: > lgtm > > FYI csharp@, this is apparently blocking ...
6 years, 6 months ago (2014-06-13 07:07:49 UTC) #8
csharp
On 2014/06/13 07:07:49, henrika wrote: > On 2014/06/12 23:37:31, robertshield wrote: > > lgtm > ...
6 years, 6 months ago (2014-06-13 12:43:31 UTC) #9
henrika (OOO until Aug 14)
6 years, 6 months ago (2014-06-15 13:59:24 UTC) #10
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/335073002/ by henrika@chromium.org.

The reason for reverting is: No crashes have been found after 37.0.2046.2 and
Canary on Windows is now on 37.0.2051.2, hence it looks good. Not sure if was
the blacklisting or the "calling CoInitializeEx twice" patch which did the trick
here.

I would like to revert the blacklisting patch to see if we can cope with the
CoInitializeEx patch only. It would be great if we could avoid adding another
DLL to the blacklist..

Powered by Google App Engine
This is Rietveld 408576698