Timeline: show record details as a tabbed pane

Timeline: show record details as a tabbed pane

This changes TimelineDetailsView to be a TabbedPane and lets us add
additional tabs for record types where we can show more details (e.g.
layer tree view or paint profiler). The old details remain in "default"
first tab. Also, for selected range stats, we now show range begin-end
as a part of details view, not in the header.

BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176414

[yurys, 2014-06-18 07:31:38]

LGTM.

https://codereview.chromium.org/325313006/diff/20001/Source/devtools/front_en...
File Source/devtools/front_end/timeline/TimelinePanel.js (right):

https://codereview.chromium.org/325313006/diff/20001/Source/devtools/front_en...
Source/devtools/front_end/timeline/TimelinePanel.js:1149:
this.changeTabTitle("default", WebInspector.UIString("Details: %s", title));
The title string may be too long for a tab title. Maybe we should should just
record type in the title?

[caseq, 2014-06-18 07:47:42]

screenshot:
https://docs.google.com/file/d/0BxDPof7W8AY_bEtjNmhac1Vob00/edit?pli=1

On 2014/06/18 07:31:38, yurys wrote:
> LGTM.
> 
>
https://codereview.chromium.org/325313006/diff/20001/Source/devtools/front_en...
> File Source/devtools/front_end/timeline/TimelinePanel.js (right):
> 
>
https://codereview.chromium.org/325313006/diff/20001/Source/devtools/front_en...
> Source/devtools/front_end/timeline/TimelinePanel.js:1149:
> this.changeTabTitle("default", WebInspector.UIString("Details: %s", title));
> The title string may be too long for a tab title. Maybe we should should just
> record type in the title?

That was the plan, but we discussed this with Pavel and he asked for "Details:".

[caseq, 2014-06-18 07:47:45]

The CQ bit was checked by caseq@chromium.org

[commit-bot: I haz the power, 2014-06-18 07:48:14]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/caseq@chromium.org/325313006/20001

[commit-bot: I haz the power, 2014-06-18 07:48:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-18 07:48:21]

Failed to apply patch for
LayoutTests/inspector/timeline/timeline-node-reference.html:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file LayoutTests/inspector/timeline/timeline-node-reference.html
  Hunk #1 FAILED at 29.
  1 out of 1 hunk FAILED -- saving rejects to file
LayoutTests/inspector/timeline/timeline-node-reference.html.rej

Patch:       LayoutTests/inspector/timeline/timeline-node-reference.html
Index: LayoutTests/inspector/timeline/timeline-node-reference.html
diff --git a/LayoutTests/inspector/timeline/timeline-node-reference.html
b/LayoutTests/inspector/timeline/timeline-node-reference.html
index
bc573cb4d6cf043470e149712acbf92d0943976e..31c64b5265f6365a7c063904411964c739b439e6
100644
--- a/LayoutTests/inspector/timeline/timeline-node-reference.html
+++ b/LayoutTests/inspector/timeline/timeline-node-reference.html
@@ -29,7 +29,7 @@ function test()
 
     function clickValueLink(record, row)
     {
-        var helper = WebInspector.TimelineUIUtils.generatePopupContent(record,
record._model, new WebInspector.Linkifier(), onDetailsContentReady);
+        var helper =
WebInspector.TimelineUIUtils.generateDetailsContent(record, record._model, new
WebInspector.Linkifier(), onDetailsContentReady);
 
         function onDetailsContentReady(element)
         {

[caseq, 2014-06-18 08:40:21]

The CQ bit was checked by caseq@chromium.org

[commit-bot: I haz the power, 2014-06-18 08:40:50]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/caseq@chromium.org/325313006/20001

[commit-bot: I haz the power, 2014-06-18 08:41:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-18 08:41:08]

Failed to apply patch for
LayoutTests/inspector/timeline/timeline-node-reference.html:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file LayoutTests/inspector/timeline/timeline-node-reference.html
  Hunk #1 FAILED at 29.
  1 out of 1 hunk FAILED -- saving rejects to file
LayoutTests/inspector/timeline/timeline-node-reference.html.rej

Patch:       LayoutTests/inspector/timeline/timeline-node-reference.html
Index: LayoutTests/inspector/timeline/timeline-node-reference.html
diff --git a/LayoutTests/inspector/timeline/timeline-node-reference.html
b/LayoutTests/inspector/timeline/timeline-node-reference.html
index
bc573cb4d6cf043470e149712acbf92d0943976e..31c64b5265f6365a7c063904411964c739b439e6
100644
--- a/LayoutTests/inspector/timeline/timeline-node-reference.html
+++ b/LayoutTests/inspector/timeline/timeline-node-reference.html
@@ -29,7 +29,7 @@ function test()
 
     function clickValueLink(record, row)
     {
-        var helper = WebInspector.TimelineUIUtils.generatePopupContent(record,
record._model, new WebInspector.Linkifier(), onDetailsContentReady);
+        var helper =
WebInspector.TimelineUIUtils.generateDetailsContent(record, record._model, new
WebInspector.Linkifier(), onDetailsContentReady);
 
         function onDetailsContentReady(element)
         {

[caseq, 2014-06-18 11:59:51]

The CQ bit was checked by caseq@chromium.org

[commit-bot: I haz the power, 2014-06-18 12:00:20]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/caseq@chromium.org/325313006/40001

[caseq, 2014-06-18 12:01:10]

The CQ bit was unchecked by caseq@chromium.org

[caseq, 2014-06-18 12:01:59]

The CQ bit was checked by caseq@chromium.org

[commit-bot: I haz the power, 2014-06-18 12:03:06]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/caseq@chromium.org/325313006/40001

[commit-bot: I haz the power, 2014-06-18 13:08:16]

Change committed as 176414