Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 325293002: Add 'enhanced_bookmarks' dependency to 'chrome_android_core'. (Closed)

Created:
6 years, 6 months ago by Kibeom Kim (inactive)
Modified:
6 years, 6 months ago
Reviewers:
Yaron
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add 'enhanced_bookmarks' dependency to 'chrome_android_core'. Chrome on Android now depends on 'enhanced_bookmarks' upstream target, so 'chrome_android_core' static library should have it as dependency. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276644

Patch Set 1 #

Total comments: 2

Patch Set 2 : TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/chrome_android.gypi View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Kibeom Kim (inactive)
6 years, 6 months ago (2014-06-11 21:14:56 UTC) #1
Yaron
https://codereview.chromium.org/325293002/diff/1/chrome/chrome_android.gypi File chrome/chrome_android.gypi (right): https://codereview.chromium.org/325293002/diff/1/chrome/chrome_android.gypi#newcode101 chrome/chrome_android.gypi:101: '../components/components.gyp:enhanced_bookmarks', How about adding a TODO(kkimlabs): Move this to ...
6 years, 6 months ago (2014-06-11 21:54:35 UTC) #2
Yaron
On 2014/06/11 21:54:35, Yaron wrote: > https://codereview.chromium.org/325293002/diff/1/chrome/chrome_android.gypi > File chrome/chrome_android.gypi (right): > > https://codereview.chromium.org/325293002/diff/1/chrome/chrome_android.gypi#newcode101 > ...
6 years, 6 months ago (2014-06-11 21:54:49 UTC) #3
Kibeom Kim (inactive)
The CQ bit was checked by kkimlabs@chromium.org
6 years, 6 months ago (2014-06-11 22:01:42 UTC) #4
Kibeom Kim (inactive)
https://codereview.chromium.org/325293002/diff/1/chrome/chrome_android.gypi File chrome/chrome_android.gypi (right): https://codereview.chromium.org/325293002/diff/1/chrome/chrome_android.gypi#newcode101 chrome/chrome_android.gypi:101: '../components/components.gyp:enhanced_bookmarks', On 2014/06/11 21:54:35, Yaron wrote: > How about ...
6 years, 6 months ago (2014-06-11 22:02:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkimlabs@chromium.org/325293002/20001
6 years, 6 months ago (2014-06-11 22:04:49 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 23:33:06 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 23:36:53 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/builds/160446) ios_rel_device on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds/149854) mac_chromium_compile_dbg ...
6 years, 6 months ago (2014-06-11 23:36:54 UTC) #9
Kibeom Kim (inactive)
The CQ bit was checked by kkimlabs@chromium.org
6 years, 6 months ago (2014-06-12 01:37:12 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkimlabs@chromium.org/325293002/20001
6 years, 6 months ago (2014-06-12 01:39:24 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-12 07:34:57 UTC) #12
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 12:51:17 UTC) #13
Message was sent while issue was closed.
Change committed as 276644

Powered by Google App Engine
This is Rietveld 408576698