|
|
Created:
6 years, 6 months ago by Kibeom Kim (inactive) Modified:
6 years, 6 months ago Reviewers:
Yaron CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Visibility:
Public. |
DescriptionAdd 'enhanced_bookmarks' dependency to 'chrome_android_core'.
Chrome on Android now depends on 'enhanced_bookmarks' upstream target,
so 'chrome_android_core' static library should have it as dependency.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276644
Patch Set 1 #
Total comments: 2
Patch Set 2 : TODO #Messages
Total messages: 13 (0 generated)
https://codereview.chromium.org/325293002/diff/1/chrome/chrome_android.gypi File chrome/chrome_android.gypi (right): https://codereview.chromium.org/325293002/diff/1/chrome/chrome_android.gypi#n... chrome/chrome_android.gypi:101: '../components/components.gyp:enhanced_bookmarks', How about adding a TODO(kkimlabs): Move this to chrome.gyp:browser when the dependendant is upstreamed
On 2014/06/11 21:54:35, Yaron wrote: > https://codereview.chromium.org/325293002/diff/1/chrome/chrome_android.gypi > File chrome/chrome_android.gypi (right): > > https://codereview.chromium.org/325293002/diff/1/chrome/chrome_android.gypi#n... > chrome/chrome_android.gypi:101: > '../components/components.gyp:enhanced_bookmarks', > How about adding a TODO(kkimlabs): Move this to chrome.gyp:browser when the > dependendant is upstreamed lgtm with that..
The CQ bit was checked by kkimlabs@chromium.org
https://codereview.chromium.org/325293002/diff/1/chrome/chrome_android.gypi File chrome/chrome_android.gypi (right): https://codereview.chromium.org/325293002/diff/1/chrome/chrome_android.gypi#n... chrome/chrome_android.gypi:101: '../components/components.gyp:enhanced_bookmarks', On 2014/06/11 21:54:35, Yaron wrote: > How about adding a TODO(kkimlabs): Move this to chrome.gyp:browser when the > dependendant is upstreamed Done.
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkimlabs@chromium.org/325293002/20001
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...) ios_dbg_simulator on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...) ios_rel_device on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...) mac_chromium_compile_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...) mac_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...) win_chromium_compile_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...) win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...) win_chromium_x64_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/15703) win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/18836)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...) ios_rel_device on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...) mac_chromium_compile_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...) mac_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...) win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/15772) win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/18904)
The CQ bit was checked by kkimlabs@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkimlabs@chromium.org/325293002/20001
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
Message was sent while issue was closed.
Change committed as 276644 |