Handlify JSObject::PrepareElementsForSort

Handlify JSObject::PrepareElementsForSort

BUG=
R=mstarzinger@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=17402

[rafaelw, 2013-10-22 23:52:12]

PTAL. I started down the road of including PrepareSlowElementsForSort in this
patch, but that looked like it might need more substantive logic changes, so I
backed off.

[rafaelw, 2013-10-22 23:52:48]

PTAL. I started down the road of including PrepareSlowElementsForSort in this
patch, but that looked like it might need more substantive logic changes, so I
backed off.

[Michael Starzinger, 2013-10-25 08:11:44]

LGTM with a couple of nits.

https://codereview.chromium.org/32523008/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/32523008/diff/1/src/objects.cc#newcode346
src/objects.cc:346: Handle<Object>
JSObject::EnsureWritableFastElements(Handle<JSObject> object) {
IIUC the return type of this function can be narrowed down to either
Handle<FixedArray> or Handle<FixedArrayBase>.

https://codereview.chromium.org/32523008/diff/1/src/objects.cc#newcode14403
src/objects.cc:14403: Handle<SeededNumberDictionary> dict =
handle(object->element_dictionary());
nit: Let's use the constructor syntax here instead of an assignment to be
consistent with the rest of the code ...

Handle<SeededNumberDictionary> dict(object->element_dictionary());

https://codereview.chromium.org/32523008/diff/1/src/objects.cc#newcode14413
src/objects.cc:14413: PretenureFlag tenure =
object->GetHeap()->InNewSpace(*object) ?
nit: Using isolate->heap() here is cheaper and cleaner.

https://codereview.chromium.org/32523008/diff/1/src/objects.cc#newcode14444
src/objects.cc:14444: if (elements_base->map() ==
object->GetHeap()->fixed_double_array_map()) {
nit: Using isolate->heap() here is cheaper and cleaner.

[rafaelw, 2013-10-25 20:23:46]

https://codereview.chromium.org/32523008/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/32523008/diff/1/src/objects.cc#newcode346
src/objects.cc:346: Handle<Object>
JSObject::EnsureWritableFastElements(Handle<JSObject> object) {
On 2013/10/25 08:11:44, Michael Starzinger wrote:
> IIUC the return type of this function can be narrowed down to either
> Handle<FixedArray> or Handle<FixedArrayBase>.

Done.

https://codereview.chromium.org/32523008/diff/1/src/objects.cc#newcode14403
src/objects.cc:14403: Handle<SeededNumberDictionary> dict =
handle(object->element_dictionary());
On 2013/10/25 08:11:44, Michael Starzinger wrote:
> nit: Let's use the constructor syntax here instead of an assignment to be
> consistent with the rest of the code ...
> 
> Handle<SeededNumberDictionary> dict(object->element_dictionary());

Done.

https://codereview.chromium.org/32523008/diff/1/src/objects.cc#newcode14413
src/objects.cc:14413: PretenureFlag tenure =
object->GetHeap()->InNewSpace(*object) ?
On 2013/10/25 08:11:44, Michael Starzinger wrote:
> nit: Using isolate->heap() here is cheaper and cleaner.

Done.

https://codereview.chromium.org/32523008/diff/1/src/objects.cc#newcode14444
src/objects.cc:14444: if (elements_base->map() ==
object->GetHeap()->fixed_double_array_map()) {
On 2013/10/25 08:11:44, Michael Starzinger wrote:
> nit: Using isolate->heap() here is cheaper and cleaner.

Done.

[rafaelw, 2013-10-25 20:42:57]

Committed patchset #2 manually as r17402 (presubmit successful).