Issue 325183003: Ignore live_edit_ flag when when dealing with LiveEdit in a debug break.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 325183003: Ignore live_edit_ flag when when dealing with LiveEdit in a debug break. (Closed)

Created:
6 years, 6 months ago by Yang

Modified:
6 years, 6 months ago

Reviewers:
ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Ignore live_edit_ flag when when dealing with LiveEdit in a debug break. LiveEdit maybe disabled when we enter the break and again when we leave it, but enabled in between. TEST=https://codereview.chromium.org/329533002 R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21770

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -15 lines)			Patch
M	src/debug.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/debug.cc	View	2 chunks	+5 lines, -8 lines	0 comments	Download
M	src/liveedit.h	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/liveedit.cc	View	3 chunks	+12 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Yang

6 years, 6 months ago (2014-06-11 13:40:24 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r21770 (presubmit successful).

Expand Messages | Collapse Messages