Source/core/rendering/RenderReplaced.cpp - Issue 325183002: Make preferred widths for replaced content independent on available width

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderReplaced.cpp

Issue 325183002: Make preferred widths for replaced content independent on available width (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add one more test Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/svg/custom/stf-container-with-intrinsic-ratio-svg.html ('K') | « LayoutTests/svg/custom/stf-container-with-intrinsic-ratio-svg.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderReplaced.cpp

diff --git a/Source/core/rendering/RenderReplaced.cpp b/Source/core/rendering/RenderReplaced.cpp

index 885b9b0493fb58393734aaa25f09e3ca56ccfce1..69bfa7180ea2da8dd1e9b601538c6a46976c4ee9 100644

--- a/Source/core/rendering/RenderReplaced.cpp

+++ b/Source/core/rendering/RenderReplaced.cpp

@@ -401,6 +401,8 @@ LayoutUnit RenderReplaced::computeReplacedLogicalWidth(ShouldComputePreferred sh

// 'width' is undefined in CSS 2.1. However, it is suggested that, if the containing block's width does not itself depend on the replaced element's width, then

// the used value of 'width' is calculated from the constraint equation used for block-level, non-replaced elements in normal flow.

if (computedHeightIsAuto && !hasIntrinsicWidth && !hasIntrinsicHeight) {

+ if (shouldComputePreferred == ComputePreferred)

+ return 0;

// The aforementioned 'constraint equation' used for block-level, non-replaced elements in normal flow:

// 'margin-left' + 'border-left-width' + 'padding-left' + 'width' + 'padding-right' + 'border-right-width' + 'margin-right' = width of containing block

LayoutUnit logicalWidth;