LayoutTests/svg/custom/stf-container-with-intrinsic-ratio-svg.html - Issue 325183002: Make preferred widths for replaced content independent on available width

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/svg/custom/stf-container-with-intrinsic-ratio-svg.html

Issue 325183002: Make preferred widths for replaced content independent on available width (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add one more test Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/svg/custom/size-follows-container-size.html ('K') | « LayoutTests/svg/custom/size-follows-container-size.html ('k') | Source/core/rendering/RenderReplaced.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../resources/testharness.js"></script>

	3 <script src="../../resources/testharnessreport.js"></script>

	4 <style type="text/css">

	5 body > div { width: 100px }

	6 #stf1 { float: left }

	7 #stf2 { position: absolute }

	8 #stf3 { display: table-cell }

	9 </style>

	10 <div>

	11 <div id="stf1">

	12 <svg viewBox='0 0 1 1'></svg>

	13 </div>

	14 <div id="stf2">

	15 <svg viewBox='0 0 1 1'></svg>

	16 </div>

	17 <div id="stf3">

	18 <svg viewBox='0 0 1 1'></svg>

	19 </div>

	20 </div>

	21 <script>

	22 test(function() {

	23 var r = document.getElementById('stf1').getBoundingClientRect();

	24 assert_equals(r.width, 0);

	25 }, "Test floated element width with replaced element with intrinsic ratio bu t no dimensions");

	26 test(function() {

	27 var r = document.getElementById('stf2').getBoundingClientRect();

	28 assert_equals(r.width, 0);

	29 }, "Test absolute positioned element width with replaced element with intrin sic ratio but no dimensions");

	30 test(function() {

	31 var r = document.getElementById('stf3').getBoundingClientRect();

	32 assert_true(r.width == 1 \|\| r.width == 0); // Unclear if width should be 0 or 1. (Firefox and Blink doesn't agree)
	pdr. 2014/06/18 17:48:43 Lets pick one but leave the comment. This will let Lets pick one but leave the comment. This will let us catch changes to this value. davve 2014/06/18 19:16:47 Fair. Will fix grammar in the comment though :) Show quoted text On 2014/06/18 17:48:43, pdr wrote: > Lets pick one but leave the comment. This will let us catch changes to this > value. Fair. Will fix grammar in the comment though :)
	33 }, "Test table cell width with replaced element with intrinsic ratio but no dimensions");

	34 </script>

OLD	NEW