content/browser/service_worker/service_worker_request_handler.cc - Issue 325173002: ServiceWorker: Confirm the liveness of the associated context before handling message

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_request_handler.cc

Issue 325173002: ServiceWorker: Confirm the liveness of the associated context before handling message (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_register_job.cc ('k') | content/browser/service_worker/service_worker_url_request_job_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_request_handler.cc

diff --git a/content/browser/service_worker/service_worker_request_handler.cc b/content/browser/service_worker/service_worker_request_handler.cc

index 3faf502ab953857cbd77b6c9d74b0c1bcf2405e2..a56557f622adee5c837383a71e3a80ac035ec024 100644

--- a/content/browser/service_worker/service_worker_request_handler.cc

+++ b/content/browser/service_worker/service_worker_request_handler.cc

@@ -7,6 +7,7 @@

#include "content/browser/service_worker/service_worker_context_core.h"

#include "content/browser/service_worker/service_worker_context_wrapper.h"

#include "content/browser/service_worker/service_worker_provider_host.h"

+#include "content/browser/service_worker/service_worker_provider_host_registry.h"

#include "content/browser/service_worker/service_worker_registration.h"

#include "content/browser/service_worker/service_worker_url_request_job.h"

#include "content/browser/service_worker/service_worker_utils.h"

@@ -69,7 +70,8 @@ void ServiceWorkerRequestHandler::InitializeHandler(

}

ServiceWorkerProviderHost* provider_host =

- context_wrapper->context()->GetProviderHost(process_id, provider_id);

+ context_wrapper->provider_registry()->GetProviderHost(

+ process_id, provider_id);

if (!provider_host)

michaeln 2014/06/11 22:02:17 also return early if !provider_host->IsAlive() ?

nhiroki 2014/06/17 08:56:15 Done.

return;