Issue 325163002: MacViews: Fix a forward declare of InputMethodDelegate in native_widget_private.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 325163002: MacViews: Fix a forward declare of InputMethodDelegate in native_widget_private.h (Closed)

Created:
6 years, 6 months ago by tapted

Modified:
6 years, 6 months ago

Reviewers:
sky

CC:
chromium-reviews, tfarina, ben+views_chromium.org, tdanderson+views_chromium.org, chrome-apps-syd-reviews_chromium.org, mac-views-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

MacViews: Fix a forward declare of InputMethodDelegate in native_widget_private.h It should be in namespace views::internal. BUG=378134 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276548

Patch Set 1 : fix #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -3 lines)			Patch
M	ui/views/widget/native_widget_mac.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/views/widget/native_widget_mac.mm	View	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/views/widget/native_widget_private.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

tapted

Hi sky.. another small one - PTAL. .. just so I'm not tacking this on ...

6 years, 6 months ago (2014-06-11 07:33:55 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/325163002/20001

6 years, 6 months ago (2014-06-12 03:13:13 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...

6 years, 6 months ago (2014-06-12 04:43:18 UTC) #5

Message was sent while issue was closed.

Change committed as 276548

Expand Messages | Collapse Messages