Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Issue 32513006: Revert 229896 "Cache force-installed apps/extensions in device-l..." (Closed)

Created:
7 years, 2 months ago by dmichael (off chromium)
Modified:
7 years, 2 months ago
Reviewers:
bartfab (slow)
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 229896 "Cache force-installed apps/extensions in device-l..." Caused a build failure: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Builder/builds/56839/steps/compile/logs/stdio ../../chrome/browser/chromeos/extensions/device_local_account_external_policy_loader.cc: In member function 'void chromeos::DeviceLocalAccountExternalPolicyLoader::UpdateExtensionListFromStore()': ../../chrome/browser/chromeos/extensions/device_local_account_external_policy_loader.cc:98:3:error: 'ExtensionInstallForcelistPolicyHandler' is not a member of 'policy' ../../chrome/browser/chromeos/extensions/device_local_account_external_policy_loader.cc:99:7:error: expected ';' before 'policy_handler' ../../chrome/browser/chromeos/extensions/device_local_account_external_policy_loader.cc:100:7:error: 'policy_handler' was not declared in this scope > Cache force-installed apps/extensions in device-local accounts > > This CL adds the DeviceLocalAccountExternalPolicyLoader, a replacement for > the ExternalPolicyLoader that caches force-installed apps/extensions, > allowing them to be installed offline. The caches for individual accounts > are managed by the DeviceLocalAccountPolicyService which makes sure to > remove obsolete cache directories. > > BUG=287802 > TEST=Full coverage with new browser and unit tests > > Review URL: https://codereview.chromium.org/27548004 TBR=bartfab@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=229897

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+377 lines, -1658 lines) Patch
D trunk/src/chrome/browser/chromeos/extensions/device_local_account_external_policy_loader.h View 1 chunk +0 lines, -78 lines 0 comments Download
D trunk/src/chrome/browser/chromeos/extensions/device_local_account_external_policy_loader.cc View 1 chunk +0 lines, -114 lines 0 comments Download
D trunk/src/chrome/browser/chromeos/extensions/device_local_account_external_policy_loader_unittest.cc View 1 chunk +0 lines, -309 lines 0 comments Download
M trunk/src/chrome/browser/chromeos/extensions/external_pref_cache_loader.h View 1 chunk +3 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/chromeos/policy/device_local_account.h View 1 chunk +0 lines, -16 lines 0 comments Download
M trunk/src/chrome/browser/chromeos/policy/device_local_account_browsertest.cc View 9 chunks +4 lines, -133 lines 0 comments Download
M trunk/src/chrome/browser/chromeos/policy/device_local_account_policy_provider.cc View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/chromeos/policy/device_local_account_policy_service.h View 8 chunks +33 lines, -68 lines 0 comments Download
M trunk/src/chrome/browser/chromeos/policy/device_local_account_policy_service.cc View 8 chunks +82 lines, -274 lines 0 comments Download
M trunk/src/chrome/browser/chromeos/policy/device_local_account_policy_service_unittest.cc View 12 chunks +235 lines, -602 lines 0 comments Download
M trunk/src/chrome/browser/chromeos/settings/device_settings_test_helper.cc View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/extensions/external_provider_impl.h View 2 chunks +2 lines, -1 line 0 comments Download
M trunk/src/chrome/browser/extensions/external_provider_impl.cc View 3 chunks +15 lines, -45 lines 0 comments Download
M trunk/src/chrome/browser/policy/browser_policy_connector.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/policy/configuration_policy_handler_list.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M trunk/src/chrome/chrome_browser_chromeos.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/chromeos/chromeos_paths.h View 1 chunk +0 lines, -3 lines 0 comments Download
M trunk/src/chromeos/chromeos_paths.cc View 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dmichael (off chromium)
7 years, 2 months ago (2013-10-21 20:19:17 UTC) #1
dmichael (off chromium)
Committed patchset #1 manually as r229897.
7 years, 2 months ago (2013-10-21 20:20:12 UTC) #2
dmichael (off chromium)
Sorry I had to revert. It looks like the ExtensionInstallForcelistPolicyHandler class moved in this change, ...
7 years, 2 months ago (2013-10-21 20:36:50 UTC) #3
bartfab (slow)
7 years, 2 months ago (2013-10-21 20:48:31 UTC) #4
Message was sent while issue was closed.
On 2013/10/21 20:36:50, dmichael wrote:
> Sorry I had to revert. It looks like the
ExtensionInstallForcelistPolicyHandler
> class moved in this change, which beat your change in the commit queue:
> https://src.chromium.org/viewvc/chrome?revision=229845&view=revision
> 
> So it should be an easy fix.

Yep, no worries. I have a fix already, am running unit and browser tests locally
before relanding.

Powered by Google App Engine
This is Rietveld 408576698