Make user shortcuts override built-in shortcuts.

Make user shortcuts override built-in shortcuts.

BUG=25330
TEST=Open sysprefs, keyboard, keyboard shortcuts, add a keyboard shortcut that makes cmd-right do "Select Next Tab". Hit cmd-right in chromium. Should switch tabs instead of doing history navigation (note "instead". If it does both tab switching _and_ history navigation, that's wrong). If a text box is focussed, cmd-right should however instead move the cursor and not switch tabs. Switching windows with cmd-` should still work. Switching tabs with cmd-1/2/3 and cmd-{/} should still work. Using backspace/shift-backspace for history should still work.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29877

[jeremy, 2009-10-23 05:22:54]

LGTM

http://codereview.chromium.org/325004/diff/1/2
File chrome/browser/tab_contents/tab_contents_view_mac.mm (right):

http://codereview.chromium.org/325004/diff/1/2#newcode340
Line 340: // dispatching to the menu as well.
"dispatching the menu" -> "Invoking the original menu item shortcut" ?

[Nico, 2009-10-23 06:08:12]

Thanks, submitting.

http://codereview.chromium.org/325004/diff/1/2
File chrome/browser/tab_contents/tab_contents_view_mac.mm (right):

http://codereview.chromium.org/325004/diff/1/2#newcode340
Line 340: // dispatching to the menu as well.
On 2009/10/23 05:22:54, jeremy wrote:
> "dispatching the menu" -> "Invoking the original menu item shortcut" ?

Done.