content/renderer/pepper/pepper_plugin_instance_impl.h - Issue 324983005: [PPAPI] Add browser tests for compositor API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/pepper/pepper_plugin_instance_impl.h

Issue 324983005: [PPAPI] Add browser tests for compositor API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@compositor_api_impl_new

Patch Set: Fix review issues Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/ppapi/ppapi_browsertest.cc ('K') | « content/renderer/pepper/pepper_compositor_host.cc ('k') | content/renderer/pepper/pepper_plugin_instance_impl.cc » ('j') | ppapi/proxy/compositor_layer_resource.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/pepper/pepper_plugin_instance_impl.h

diff --git a/content/renderer/pepper/pepper_plugin_instance_impl.h b/content/renderer/pepper/pepper_plugin_instance_impl.h

index 5fb61d8716c9931659a29b4a5a220ada56fe84e0..e3a8324e2841946df3cc975dbd7c77178716ecd8 100644

--- a/content/renderer/pepper/pepper_plugin_instance_impl.h

+++ b/content/renderer/pepper/pepper_plugin_instance_impl.h

@@ -629,7 +629,7 @@ class CONTENT_EXPORT PepperPluginInstanceImpl

// - we are not in Flash full-screen mode (or transitioning to it)

// Otherwise it destroys the layer.

// It does either operation lazily.

- void UpdateLayer();

+ void UpdateLayer(bool device_changed);

raymes 2014/06/18 05:58:44 Maybe add a comment explaining what the parameter

Peng 2014/06/18 11:14:36 Done.

// Internal helper function for PrintPage().

bool PrintPageHelper(PP_PrintPageNumberRange_Dev* page_ranges,